Fix for #568

Author: mevdschee

api.php

@@ -5131,6 +5131,8 @@ public function convertRecords(ReflectedTable $table, array $columnNames, array
         private function convertInputValue($conversion, $value)
         {
             switch ($conversion) {
+                case 'boolean':
+                    return $value ? 1 : 0;
                 case 'base64url_to_base64':
                     return str_pad(strtr($value, '-_', '+/'), ceil(strlen($value) / 4) * 4, '=', STR_PAD_RIGHT);
             }
@@ -5139,6 +5141,9 @@ private function convertInputValue($conversion, $value)
 
         private function getInputValueConversion(ReflectedColumn $column): string
         {
+            if ($column->isBoolean()) {
+                return 'boolean';
+            }
             if ($column->isBinary()) {
                 return 'base64url_to_base64';
             }
@@ -9793,18 +9798,28 @@ private function parseBody(string $body) /*: ?object*/
 
         private function addParsedBody(ServerRequestInterface $request): ServerRequestInterface
         {
-            $contents = '';
             $parsedBody = $request->getParsedBody();
             if ($parsedBody) {
-                $contents = json_encode($parsedBody);
+                $request = $this->applySlim3Hack($request);
             } else {
                 $body = $request->getBody();
                 if ($body->isReadable() && $body->isSeekable()) {
                     $contents = $body->getContents();
                     $body->rewind();
+                    if ($contents) {
+                        $parsedBody = $this->parseBody($contents);
+                        $request = $request->withParsedBody($parsedBody);
+                    }
                 }
             }
-            if ($contents) {
+            return $request;
+        }
+
+        private function applySlim3Hack(ServerRequestInterface $request): ServerRequestInterface
+        {
+            if (get_class($request) == 'Slim\Http\Request') {
+                $parsedBody = $request->getParsedBody();
+                $contents = json_encode($parsedBody);
                 $parsedBody = $this->parseBody($contents);
                 $request = $request->withParsedBody($parsedBody);
             }

src/Tqdev/PhpCrudApi/Api.php

@@ -160,18 +160,28 @@ private function parseBody(string $body) /*: ?object*/
 
     private function addParsedBody(ServerRequestInterface $request): ServerRequestInterface
     {
-        $contents = '';
         $parsedBody = $request->getParsedBody();
         if ($parsedBody) {
-            $contents = json_encode($parsedBody);
+            $request = $this->applySlim3Hack($request);
         } else {
             $body = $request->getBody();
             if ($body->isReadable() && $body->isSeekable()) {
                 $contents = $body->getContents();
                 $body->rewind();
+                if ($contents) {
+                    $parsedBody = $this->parseBody($contents);
+                    $request = $request->withParsedBody($parsedBody);
+                }
             }
         }
-        if ($contents) {
+        return $request;
+    }
+
+    private function applySlim3Hack(ServerRequestInterface $request): ServerRequestInterface
+    {
+        if (get_class($request) == 'Slim\Http\Request') {
+            $parsedBody = $request->getParsedBody();
+            $contents = json_encode($parsedBody);
             $parsedBody = $this->parseBody($contents);
             $request = $request->withParsedBody($parsedBody);
         }

src/Tqdev/PhpCrudApi/Database/DataConverter.php

@@ -56,6 +56,8 @@ public function convertRecords(ReflectedTable $table, array $columnNames, array
     private function convertInputValue($conversion, $value)
     {
         switch ($conversion) {
+            case 'boolean':
+                return $value ? 1 : 0;
             case 'base64url_to_base64':
                 return str_pad(strtr($value, '-_', '+/'), ceil(strlen($value) / 4) * 4, '=', STR_PAD_RIGHT);
         }
@@ -64,6 +66,9 @@ private function convertInputValue($conversion, $value)
 
     private function getInputValueConversion(ReflectedColumn $column): string
     {
+        if ($column->isBoolean()) {
+            return 'boolean';
+        }
         if ($column->isBinary()) {
             return 'base64url_to_base64';
         }

tests/functional/001_records/084_update_tags_with_boolean.log

@@ -0,0 +1,43 @@
+GET /records/tags/1
+===
+200
+Content-Type: application/json
+Content-Length: 44
+
+{"id":1,"name":"funny","is_important":false}
+===
+PUT /records/tags/1
+
+{"id":1,"name":"funny","is_important":true}
+===
+200
+Content-Type: application/json
+Content-Length: 1
+
+1
+===
+GET /records/tags/1
+===
+200
+Content-Type: application/json
+Content-Length: 43
+
+{"id":1,"name":"funny","is_important":true}
+===
+PUT /records/tags/1
+
+{"id":1,"name":"funny","is_important":false}
+===
+200
+Content-Type: application/json
+Content-Length: 1
+
+1
+===
+GET /records/tags/1
+===
+200
+Content-Type: application/json
+Content-Length: 44
+
+{"id":1,"name":"funny","is_important":false}