Feat/Added RBAC by jacknbeans · Pull Request #2 · michaelhthomas/seerr

jacknbeans · 2025-03-28T18:29:36Z

Description

The 'Required Claims' setting was not sufficient for working with Authelia RBAC. This is a very simple implementation.

Screenshot (if UI-related)

To-Dos

Successful build pnpm build
Translation keys pnpm i18n:extract
Database migration (if required)

…for user authorization This adds 'Role Claim', 'User Roles', and 'Admin Roles' to the OIDC provider configuration modal. This is a basic implementation and only checks if the user has any of the defined user/admin roles it doesn't actually give anybody with admin roles privileged access yet.

…search user info object Also removed the admin roles as I think that was flying in the face of how Jellyseerr likes to handle it's admin accounts.

…laim' setting

jacknbeans · 2025-03-28T18:38:01Z

-  url.searchParams.set('scope', 'openid profile email');
+  url.searchParams.set(
+    'scope',
+    provider.scopes?.replaceAll(',', ' ') ?? 'openid profile email'


Accidentally included this change without commenting on it, but seemed like the OIDC provider setting wasn't being used here. So changed it to use the default if it's not set by the user.

yep, nice catch!

jacknbeans · 2025-03-28T22:31:28Z

Seems that the 'Remove from Radarr/Sonarr' button in the requests page is broken. Will investigate if it's tied to my changes.

gauthier-th · 2025-03-29T17:17:59Z

Seems that the 'Remove from Radarr/Sonarr' button in the requests page is broken. Will investigate if it's tied to my changes.

This is not introduced by you. It's a bug we introduced and already existing on develop.

…to feat/oidc-login

ar3s3ru · 2025-07-05T18:25:00Z

Hi folks, I'd like to make use of this feature. What's the blocker in merging this PR?

…eerr-team#1491) * feat(wehbook): add support for dynamic placeholders in webhook URL * refactor(webhook): rename supportPlaceholders to supportVariables and update related logic Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me> * feat(i18n): add missing translations Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me> * refactor(notifications): simplify webhook URL validation logic Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me> * fix: wrong docs url Co-authored-by: Gauthier <mail@gauthierth.fr> * fix: update webhook documentation URL to point to Jellyseerr Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me> --------- Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me> Co-authored-by: Gauthier <mail@gauthierth.fr>

…r-team#1907)

…team#1908) Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me>

…caching (seerr-team#1910) * fix: ensure dnsCache is checked for when its enabled before initialization previously dnsCache was being initialized even if it was disabled because the previous check was always returning truthy. fix seerr-team#1857 * chore: update dns-caching to 0.2.6 This will allow dns-caching to respect forceIpv4 flag. * chore: update dns-caching to 0.2.7

…err-team#1914)

* build(docker): setup rootless image --------- Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>

… with scan disabled (seerr-team#2043)

Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>

@fallenbagel

* ci: update to release workflow * build: re-ran lock file update with typeorm 0.3.12 * build: resync lockfile with develop * ci: syntax fix in cliff.toml * Update .github/workflows/release.yml Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * reverting co-pilots nonsense @fallenbagel's fault Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>

* docs: added guide for image verification * Update verifying-signed-images.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* fix: update github repo refs for docker hub * ci: updated wf to use env var for the docker hub space

Updated warning message for HAProxy documentation. And fixed a typo

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…p ci] Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>

* docs: add documentation for dockerhub Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr> * docs: typo fixes --------- Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr> Co-authored-by: sudo-kraken <joe@j-harrison.co.uk>

…oads (seerr-team#2065)

fix: add endpoint deletion on disable fix: use definemessages util refactor: add code comment

…chart versions (seerr-team#2064) * ci: added helm cosign verification and renovate app workflow to bump chart versions * docs: add helm artifacts verification Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr> * fix: update app id Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr> * docs: add documentation link in helm chart and seerr docs Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr> --------- Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr> Co-authored-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>

) Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me>

* refactor(adds package): this adds the validator package and removes email-validator from dependencys * refactor(auth.ts and email.ts): migrates from EmailValidator to validator

…r-team#2068) * docs: migrate third party documentation to a dedidcated folders --------- Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>

fix seerr-team#1846

…to feat/oidc-login

…viders

github-actions · 2026-02-18T01:35:37Z

This pull request has merge conflicts. Please resolve the conflicts so the PR can be successfully reviewed and merged.

michaelhthomas and others added 9 commits March 24, 2025 19:19

feat: basic OpenID Connect support

d680994

feat: add OpenID Connect options to login screen

75f4e6b

feat: add openid connect settings interface

dc875b0

fix: tweak login buttons to ensure labels fit

3094fc2

fix: add database migrations

d6e8c93

fix(oidc login): user defined OIDC provider 'Role Claim' now used to …

9f0ddb4

…search user info object Also removed the admin roles as I think that was flying in the face of how Jellyseerr likes to handle it's admin accounts.

refactor(oidc login): checking if user has actually defined a 'Role C…

728a305

…laim' setting

chore(oidc login): added i18n for new UI fields

f9d62cc

jacknbeans commented Mar 28, 2025

View reviewed changes

jacknbeans force-pushed the feat/oidc-login branch from e3af034 to f9d62cc Compare March 28, 2025 22:12

michaelhthomas and others added 4 commits April 7, 2025 10:54

fix: improve error handling, process callback on login page

562e255

Merge branch 'feat/oidc-login' into feat/oidc-login

25e5534

chore: merge fallenbagel/develop into jacknbeans/oidc-login

d89f538

Merge branch 'feat/oidc-login' of github.com:jacknbeans/jellyseerr in…

d3108a8

…to feat/oidc-login

michaelhthomas force-pushed the feat/oidc-login branch 4 times, most recently from fa9adf0 to 39b6f47 Compare July 6, 2025 00:51

michaelhthomas force-pushed the feat/oidc-login branch 2 times, most recently from ff1c1f2 to 7f39794 Compare September 8, 2025 18:08

0xSysR3ll and others added 6 commits September 10, 2025 17:20

fix(prettier): include sw.js file in .prettierignore (seerr-team#1885)

d5bf175

fix(api): catch error when watchlist item doesn't exist anymore (seer…

e9f2f44

…r-team#1907)

feat(api): add excludeKeywords parameter to discovery queries (seerr-…

cd479d0

…team#1908) Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me>

fix(watchlist): handle undefined Guid for Plex watchlist metadata (se…

328517c

…err-team#1914)

saltydk and others added 28 commits October 12, 2025 17:19

fix(api): cleanup radarr bits in sonarr api (seerr-team#2035)

a8c7e35

build(docker): setup rootless image (seerr-team#2032) [skip ci]

0354deb

* build(docker): setup rootless image --------- Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>

fix(subscriber): prevent infinite loop when requesting existing media…

d5ff0c1

… with scan disabled (seerr-team#2043)

chore: use ghcr.io instead of dockerhub as default (seerr-team#2045)

9d174ba

Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>

docs: postgres 18 documentation (seerr-team#2046)

d95ccca

Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>

fix: path in docs and compose for postgres 18 (seerr-team#2049)

de0e9b1

docs: added guide for image verification (seerr-team#2051)

618563c

* docs: added guide for image verification * Update verifying-signed-images.mdx Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

fix: update github repo refs for docker hub (seerr-team#2053)

a988f8e

* fix: update github repo refs for docker hub * ci: updated wf to use env var for the docker hub space

docs: add haproxy configuration example (seerr-team#2048)

f3d8f0d

docs: HAProxy documentation warning format (seerr-team#2054)

c4236dc

Updated warning message for HAProxy documentation. And fixed a typo

ci(actions): update github actions (seerr-team#2022)

a0893a5

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

ci(actions): update github/codeql-action action to v4 (seerr-team#2056)

669facc

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

ci: fix concurrency issue on support workflows (seerr-team#2062) [ski…

81eab74

…p ci] Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>

fix(download-tracker): reset both service caches when resetting downl…

0d6bfa1

…oads (seerr-team#2065)

fix: delete endpoint on push notification disable (seerr-team#2067)

a975ab2

fix: add endpoint deletion on disable fix: use definemessages util refactor: add code comment

fix(api): correct Jellyfin users endpoint documentation (seerr-team#2073

a790934

) Signed-off-by: 0xsysr3ll <0xsysr3ll@pm.me>

feat: migrate to validator from email-validator (seerr-team#2059)

f7f00ce

* refactor(adds package): this adds the validator package and removes email-validator from dependencys * refactor(auth.ts and email.ts): migrates from EmailValidator to validator

docs: migrate third-parties documentation to a dedicated folder (seer…

48a61d8

…r-team#2068) * docs: migrate third party documentation to a dedidcated folders --------- Signed-off-by: Ludovic Ortega <ludovic.ortega@adminafk.fr>

feat: do not enforce TLD on email (seerr-team#2075)

b34ca15

fix seerr-team#1846

chore: merge branch 'develop' of github.com:fallenbagel/jellyseerr in…

2057329

…to feat/oidc-login

chore: missing type import for Public OidcProvider

d61f312

chore: added missing dependency for oidc login

da9a00e

chore: fixed missing imports

262cd2c

chore: added missing openIdProviders setting option

f9e65a0

chore: wrong settings were set for getFullPublicSettings for oidc pro…

eb89653

…viders

github-actions Bot added the merge conflict label Feb 18, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat/Added RBAC#2

Feat/Added RBAC#2
jacknbeans wants to merge 100 commits into
michaelhthomas:feat/oidc-loginfrom
jacknbeans:feat/oidc-login

jacknbeans commented Mar 28, 2025 •

edited

Loading

Uh oh!

jacknbeans Mar 28, 2025

Uh oh!

michaelhthomas Apr 7, 2025

Uh oh!

jacknbeans commented Mar 28, 2025

Uh oh!

gauthier-th commented Mar 29, 2025

Uh oh!

ar3s3ru commented Jul 5, 2025

Uh oh!

github-actions Bot commented Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

Conversation

jacknbeans commented Mar 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Screenshot (if UI-related)

To-Dos

Uh oh!

jacknbeans Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

michaelhthomas Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

jacknbeans commented Mar 28, 2025

Uh oh!

gauthier-th commented Mar 29, 2025

Uh oh!

ar3s3ru commented Jul 5, 2025

Uh oh!

github-actions Bot commented Feb 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

jacknbeans commented Mar 28, 2025 •

edited

Loading