Refactoring; introduce cluster definition diffing

Author: michaelklishin

src/commons.rs

@@ -534,7 +534,7 @@ impl From<BindingDestinationType> for String {
     }
 }
 
-#[derive(Eq, PartialEq, Debug, Deserialize, Serialize, Clone)]
+#[derive(Eq, PartialEq, Debug, Deserialize, Serialize, Clone, Copy)]
 #[serde(rename_all = "snake_case")]
 pub enum PolicyTarget {
     Queues,
@@ -614,7 +614,7 @@ impl PolicyTarget {
 
 impl fmt::Display for PolicyTarget {
     fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
-        write!(f, "{}", Into::<String>::into(self.clone()))?;
+        write!(f, "{}", Into::<String>::into(*self))?;
 
         Ok(())
     }

src/requests/federation.rs

@@ -14,6 +14,7 @@
 
 use crate::commons::{ChannelUseMode, MessageTransferAcknowledgementMode, QueueType};
 use crate::requests::parameters::RuntimeParameterDefinition;
+use crate::responses::FederationUpstream;
 use serde::{Deserialize, Serialize};
 use serde_json::{Map, json};
 use std::fmt::{Display, Formatter, Result};
@@ -288,8 +289,8 @@ pub struct OwnedExchangeFederationParams {
     pub resource_cleanup_mode: FederationResourceCleanupMode,
 }
 
-impl From<crate::responses::FederationUpstream> for OwnedFederationUpstreamParams {
-    fn from(upstream: crate::responses::FederationUpstream) -> Self {
+impl From<FederationUpstream> for OwnedFederationUpstreamParams {
+    fn from(upstream: FederationUpstream) -> Self {
         // Create queue federation parameters if queue-related fields are present
         let queue_federation = if upstream.queue.is_some() || upstream.consumer_tag.is_some() {
             Some(OwnedQueueFederationParams {

src/requests/policies.rs

@@ -47,7 +47,7 @@ impl<'a> From<&'a Policy> for PolicyParams<'a> {
             vhost: &policy.vhost,
             name: &policy.name,
             pattern: &policy.pattern,
-            apply_to: policy.apply_to.clone(),
+            apply_to: policy.apply_to,
             priority: policy.priority as i32,
             definition: policy.definition.clone().into(),
         }