Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable ingress annotations and command for forwarded IPs #1552

Open
shreddd opened this issue Feb 25, 2025 · 0 comments
Open

enable ingress annotations and command for forwarded IPs #1552

shreddd opened this issue Feb 25, 2025 · 0 comments
Assignees

Comments

@shreddd
Copy link
Contributor

shreddd commented Feb 25, 2025

Similar to the runtime API we should enable ingress annotations on data portal to pass along proxy headers / allow forwarded IPs

See: https://github.com/microbiomedata/infra-admin/issues/167

Note that this has 2 potential benefits

  1. Prevents FASTAPI from sending incorrect location redirects (since it knows about proxy headers)
  2. Allows us to see where source traffic is coming from.

I think this may end up requiring switching the backend from gunicorn to uvicorn, so it may need to be folded into a bigger issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants