You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
We currently have some light mixing of ES6 style import/export syntax and common JS require. I'm specifically referring to the use of images for the study detail page:
I think it would be good to favor one style of imports over the other. The vast majority of our code base uses import/export, so we should update to statements like:
importgoldfrom @/assets/gold.png
In order to appease typescript, we might also need to add a type declaration file so it knows how to treat these imports. Something like: https://stackoverflow.com/a/54137233
The text was updated successfully, but these errors were encountered:
We currently have some light mixing of ES6 style
import
/export
syntax and common JSrequire
. I'm specifically referring to the use of images for the study detail page:nmdc-server/web/src/views/IndividualResults/StudyPage.vue
Lines 222 to 229 in da8bb30
And the biosample detail page (see PR #1577).
I think it would be good to favor one style of imports over the other. The vast majority of our code base uses
import
/export
, so we should update to statements like:In order to appease typescript, we might also need to add a type declaration file so it knows how to treat these imports. Something like: https://stackoverflow.com/a/54137233
The text was updated successfully, but these errors were encountered: