Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation around websockets #11597

Open
melix opened this issue Feb 18, 2025 · 1 comment
Open

Improve documentation around websockets #11597

melix opened this issue Feb 18, 2025 · 1 comment

Comments

@melix
Copy link
Contributor

melix commented Feb 18, 2025

Issue description

While working on a pet project I found a couple issues with the websocket documentation:

  1. make it clear that you need to have all @OnOpen, @OnMessage and @OnClose methods. Any missing one, even if it does nothing, will result in a bean missing exception, which is confusing
  2. clarify how to use a web socket client. There are both WebSocketClient and ClientWebSocket, you need both, but both accept an URI. Also it's extremely unclear whether it's possible to have a non reactive websocket client.
@graemerocher
Copy link
Contributor

  1. we should fail with a compilation error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants