Added unit tests for notification and tooling

Author: abdulanu0

.coverage

@@ -2,4 +2,4 @@
 
 """
 Unit tests for Microsoft Agents A365 Notifications module.
-"""
+"""

tests/notifications/__init__.py …oft-agents-a365-notification/__init__.pytests/notifications/__init__.py renamed to tests/microsoft-agents-a365-notification/__init__.py tests/notifications/__init__.py renamed to tests/microsoft-agents-a365-notification/__init__.py

@@ -2,4 +2,4 @@
 
 """
 Unit tests for Microsoft Agents A365 Notifications models.
-"""
+"""

tests/notifications/models/__init__.py …nts-a365-notification/models/__init__.pytests/notifications/models/__init__.py renamed to tests/microsoft-agents-a365-notification/models/__init__.py tests/notifications/models/__init__.py renamed to tests/microsoft-agents-a365-notification/models/__init__.py

@@ -19,21 +19,23 @@ class ChannelId:
         MSTeams = "msteams"
         Directline = "directline"
         Webchat = "webchat"
-    
+
     class Activity:
         def __init__(self, **kwargs):
             for k, v in kwargs.items():
                 setattr(self, k, v)
-    
+
     class TurnContext:
         def __init__(self, **kwargs):
             for k, v in kwargs.items():
                 setattr(self, k, v)
-    
+
     class TurnState:
         def __init__(self, **kwargs):
             for k, v in kwargs.items():
                 setattr(self, k, v)
+
+
 from microsoft_agents_a365.notifications.agent_notification import AgentNotification
 from microsoft_agents_a365.notifications.models.agent_notification_activity import (
     AgentNotificationActivity,
@@ -409,4 +411,4 @@ async def test_route_selector_unknown_subchannel(self):
         result = route_selector(mock_context)
 
         # Assert
-        assert result is False
+        assert result is False

…ations/models/test_agent_notification.py …cation/models/test_agent_notification.pytests/notifications/models/test_agent_notification.py renamed to tests/microsoft-agents-a365-notification/models/test_agent_notification.py tests/notifications/models/test_agent_notification.py renamed to tests/microsoft-agents-a365-notification/models/test_agent_notification.py

@@ -20,8 +20,10 @@
 
 class TestAgentNotificationActivity:
     """Test cases for AgentNotificationActivity class"""
-    
-    def _create_mock_activity(self, entities=None, name="agentLifecycle", channel_id=None, value=None, type="message"):
+
+    def _create_mock_activity(
+        self, entities=None, name="agentLifecycle", channel_id=None, value=None, type="message"
+    ):
         """Helper to create properly configured mock activity"""
         mock_activity = Mock(spec=Activity)
         # Directly set attributes to ensure they're accessible
@@ -108,7 +110,7 @@ def test_init_with_multiple_entities(self):
         mock_email_entity.properties = {"type": "emailNotification"}
 
         mock_wpx_entity = Mock()
-        mock_wpx_entity.type = "WPXCOMMENT" 
+        mock_wpx_entity.type = "WPXCOMMENT"
         mock_wpx_entity.properties = {"type": "wpxComment"}
 
         mock_activity = self._create_mock_activity(entities=[mock_email_entity, mock_wpx_entity])
@@ -172,7 +174,7 @@ def test_sub_channel_property_with_channel_id(self):
         # Arrange
         mock_channel_id = Mock()
         mock_channel_id.sub_channel = "testSubChannel"
-        
+
         mock_activity = self._create_mock_activity(entities=None, channel_id=mock_channel_id)
 
         ana = AgentNotificationActivity(mock_activity)
@@ -229,10 +231,7 @@ def test_email_property_returns_parsed_email(self):
         # Arrange
         mock_email_entity = Mock()
         mock_email_entity.type = "EMAILNOTIFICATION"
-        mock_email_entity.properties = {
-            "type": "emailNotification",
-            "id": "test-email-id"
-        }
+        mock_email_entity.properties = {"type": "emailNotification", "id": "test-email-id"}
 
         mock_activity = self._create_mock_activity(entities=[mock_email_entity])
 
@@ -250,10 +249,7 @@ def test_wpx_comment_property_returns_parsed_comment(self):
         # Arrange
         mock_wpx_entity = Mock()
         mock_wpx_entity.type = "WPXCOMMENT"
-        mock_wpx_entity.properties = {
-            "type": "wpxComment",
-            "odataId": "test-comment-id"
-        }
+        mock_wpx_entity.properties = {"type": "wpxComment", "odataId": "test-comment-id"}
 
         mock_activity = self._create_mock_activity(entities=[mock_wpx_entity])
 
@@ -329,7 +325,9 @@ def test_duplicate_entity_type_handling(self):
         mock_email_entity2.type = "EMAILNOTIFICATION"
         mock_email_entity2.properties = {"type": "emailNotification", "id": "second"}
 
-        mock_activity = self._create_mock_activity(entities=[mock_email_entity1, mock_email_entity2])
+        mock_activity = self._create_mock_activity(
+            entities=[mock_email_entity1, mock_email_entity2]
+        )
 
         # Act
         ana = AgentNotificationActivity(mock_activity)
@@ -363,7 +361,7 @@ def test_entity_parsing_only_first_entity_of_each_type(self):
         email_entity1.properties = {"type": "emailNotification", "id": "email1"}
 
         email_entity2 = Mock()
-        email_entity2.type = "EMAILNOTIFICATION" 
+        email_entity2.type = "EMAILNOTIFICATION"
         email_entity2.properties = {"type": "emailNotification", "id": "email2"}
 
         mock_activity = self._create_mock_activity(entities=[email_entity1, email_entity2])
@@ -377,7 +375,7 @@ def test_entity_parsing_only_first_entity_of_each_type(self):
 
     def test_as_model_with_none_value(self):
         """Test as_model method with None value"""
-        # Arrange  
+        # Arrange
         mock_activity = self._create_mock_activity(entities=None, value=None)
 
         mock_model_class = Mock()
@@ -388,4 +386,4 @@ def test_as_model_with_none_value(self):
         result = ana.as_model(mock_model_class)
 
         # Assert
-        mock_model_class.model_validate.assert_called_once_with({})
+        mock_model_class.model_validate.assert_called_once_with({})

…dels/test_agent_notification_activity.py …dels/test_agent_notification_activity.pytests/notifications/models/test_agent_notification_activity.py renamed to tests/microsoft-agents-a365-notification/models/test_agent_notification_activity.py tests/notifications/models/test_agent_notification_activity.py renamed to tests/microsoft-agents-a365-notification/models/test_agent_notification_activity.py

@@ -27,9 +27,7 @@ def test_init_with_all_values(self):
         """Test EmailReference initialization with all values provided"""
         # Arrange & Act
         email_ref = EmailReference(
-            id="email-123",
-            conversation_id="conv-456",
-            html_body="<p>Test email content</p>"
+            id="email-123", conversation_id="conv-456", html_body="<p>Test email content</p>"
         )
 
         # Assert
@@ -41,10 +39,7 @@ def test_init_with_all_values(self):
     def test_init_with_partial_values(self):
         """Test EmailReference initialization with only some values"""
         # Arrange & Act
-        email_ref = EmailReference(
-            id="email-789",
-            conversation_id="conv-101112"
-        )
+        email_ref = EmailReference(id="email-789", conversation_id="conv-101112")
 
         # Assert
         assert email_ref.type == NotificationTypes.EMAIL_NOTIFICATION
@@ -67,7 +62,7 @@ def test_model_validate_from_dict_with_all_fields(self):
         data = {
             "id": "test-email-id",
             "conversation_id": "test-conv-id",
-            "html_body": "<html><body>Test content</body></html>"
+            "html_body": "<html><body>Test content</body></html>",
         }
 
         # Act
@@ -82,9 +77,7 @@ def test_model_validate_from_dict_with_all_fields(self):
     def test_model_validate_from_dict_with_partial_fields(self):
         """Test creating EmailReference from dictionary with partial fields"""
         # Arrange
-        data = {
-            "id": "partial-email-id"
-        }
+        data = {"id": "partial-email-id"}
 
         # Act
         email_ref = EmailReference.model_validate(data)
@@ -116,7 +109,7 @@ def test_model_validate_with_extra_fields(self):
             "id": "test-id",
             "conversation_id": "test-conv",
             "extra_field": "should_be_ignored_or_handled",
-            "another_extra": 123
+            "another_extra": 123,
         }
 
         # Act
@@ -131,11 +124,7 @@ def test_model_validate_with_extra_fields(self):
     def test_model_validate_with_none_values(self):
         """Test model validation with explicit None values"""
         # Arrange
-        data = {
-            "id": None,
-            "conversation_id": None,
-            "html_body": None
-        }
+        data = {"id": None, "conversation_id": None, "html_body": None}
 
         # Act
         email_ref = EmailReference.model_validate(data)
@@ -152,15 +141,15 @@ def test_properties_are_accessible(self):
         email_ref = EmailReference(
             id="prop-test-id",
             conversation_id="prop-test-conv",
-            html_body="<div>Property test content</div>"
+            html_body="<div>Property test content</div>",
         )
 
         # Act & Assert
-        assert hasattr(email_ref, 'id')
-        assert hasattr(email_ref, 'conversation_id')
-        assert hasattr(email_ref, 'html_body')
-        assert hasattr(email_ref, 'type')
-        
+        assert hasattr(email_ref, "id")
+        assert hasattr(email_ref, "conversation_id")
+        assert hasattr(email_ref, "html_body")
+        assert hasattr(email_ref, "type")
+
         assert email_ref.id == "prop-test-id"
         assert email_ref.conversation_id == "prop-test-conv"
         assert email_ref.html_body == "<div>Property test content</div>"
@@ -199,13 +188,13 @@ def test_id_with_various_formats(self):
             "email_123456",
             "msg-abcd-efgh-1234",
             "[email protected]",
-            "12345"
+            "12345",
         ]
 
         for test_id in test_ids:
             # Act
             email_ref = EmailReference(id=test_id)
-            
+
             # Assert
             assert email_ref.id == test_id
             assert email_ref.type == NotificationTypes.EMAIL_NOTIFICATION
@@ -217,13 +206,13 @@ def test_conversation_id_formats(self):
             "conv-123",
             "conversation_abcd1234",
             "thread-xyz-789",
-            "19:[email protected]"
+            "19:[email protected]",
         ]
 
         for conv_id in test_conv_ids:
             # Act
             email_ref = EmailReference(conversation_id=conv_id)
-            
+
             # Assert
             assert email_ref.conversation_id == conv_id
             assert email_ref.type == NotificationTypes.EMAIL_NOTIFICATION
@@ -232,21 +221,15 @@ def test_model_equality_comparison(self):
         """Test equality comparison between EmailReference instances"""
         # Arrange
         email_ref1 = EmailReference(
-            id="test-id",
-            conversation_id="test-conv",
-            html_body="<p>Test</p>"
+            id="test-id", conversation_id="test-conv", html_body="<p>Test</p>"
         )
-        
+
         email_ref2 = EmailReference(
-            id="test-id",
-            conversation_id="test-conv", 
-            html_body="<p>Test</p>"
+            id="test-id", conversation_id="test-conv", html_body="<p>Test</p>"
         )
-        
+
         email_ref3 = EmailReference(
-            id="different-id",
-            conversation_id="test-conv",
-            html_body="<p>Test</p>"
+            id="different-id", conversation_id="test-conv", html_body="<p>Test</p>"
         )
 
         # Act & Assert
@@ -257,9 +240,7 @@ def test_model_dict_representation(self):
         """Test dictionary representation of EmailReference"""
         # Arrange
         email_ref = EmailReference(
-            id="dict-test-id",
-            conversation_id="dict-test-conv",
-            html_body="<p>Dict test</p>"
+            id="dict-test-id", conversation_id="dict-test-conv", html_body="<p>Dict test</p>"
         )
 
         # Act
@@ -270,6 +251,6 @@ def test_model_dict_representation(self):
             "type": "emailNotification",
             "id": "dict-test-id",
             "conversation_id": "dict-test-conv",
-            "html_body": "<p>Dict test</p>"
+            "html_body": "<p>Dict test</p>",
         }
-        assert email_dict == expected_dict
+        assert email_dict == expected_dict

…fications/models/test_email_reference.py …ification/models/test_email_reference.pytests/notifications/models/test_email_reference.py renamed to tests/microsoft-agents-a365-notification/models/test_email_reference.py tests/notifications/models/test_email_reference.py renamed to tests/microsoft-agents-a365-notification/models/test_email_reference.py

@@ -14,9 +14,9 @@ class TestNotificationTypes:
     def test_enum_values_exist(self):
         """Test that all expected enum values exist"""
         # Assert
-        assert hasattr(NotificationTypes, 'EMAIL_NOTIFICATION')
-        assert hasattr(NotificationTypes, 'WPX_COMMENT')
-        assert hasattr(NotificationTypes, 'AGENT_LIFECYCLE')
+        assert hasattr(NotificationTypes, "EMAIL_NOTIFICATION")
+        assert hasattr(NotificationTypes, "WPX_COMMENT")
+        assert hasattr(NotificationTypes, "AGENT_LIFECYCLE")
 
     def test_enum_string_values(self):
         """Test that enum values have correct string representations"""
@@ -38,7 +38,7 @@ def test_enum_string_equality(self):
         assert NotificationTypes.EMAIL_NOTIFICATION == "emailNotification"
         assert NotificationTypes.WPX_COMMENT == "wpxComment"
         assert NotificationTypes.AGENT_LIFECYCLE == "agentLifecycle"
-        
+
         # Test inequality
         assert NotificationTypes.EMAIL_NOTIFICATION != "wpxComment"
         assert NotificationTypes.WPX_COMMENT != "agentLifecycle"
@@ -72,7 +72,7 @@ def test_enum_membership_check(self):
         """Test checking membership in enum"""
         # Act & Assert
         all_values = [nt.value for nt in NotificationTypes]
-        
+
         assert "emailNotification" in all_values
         assert "wpxComment" in all_values
         assert "agentLifecycle" in all_values
@@ -160,19 +160,19 @@ def test_enum_in_collections(self):
         notification_list = [
             NotificationTypes.EMAIL_NOTIFICATION,
             NotificationTypes.WPX_COMMENT,
-            NotificationTypes.AGENT_LIFECYCLE
+            NotificationTypes.AGENT_LIFECYCLE,
         ]
-        
+
         notification_set = {
             NotificationTypes.EMAIL_NOTIFICATION,
             NotificationTypes.WPX_COMMENT,
-            NotificationTypes.AGENT_LIFECYCLE
+            NotificationTypes.AGENT_LIFECYCLE,
         }
-        
+
         notification_dict = {
             NotificationTypes.EMAIL_NOTIFICATION: "handle_email",
             NotificationTypes.WPX_COMMENT: "handle_wpx",
-            NotificationTypes.AGENT_LIFECYCLE: "handle_lifecycle"
+            NotificationTypes.AGENT_LIFECYCLE: "handle_lifecycle",
         }
 
         # Act & Assert
@@ -186,7 +186,7 @@ def test_enum_as_dictionary_keys(self):
         handlers = {
             NotificationTypes.EMAIL_NOTIFICATION: lambda: "email_handler",
             NotificationTypes.WPX_COMMENT: lambda: "wpx_handler",
-            NotificationTypes.AGENT_LIFECYCLE: lambda: "lifecycle_handler"
+            NotificationTypes.AGENT_LIFECYCLE: lambda: "lifecycle_handler",
         }
 
         # Act & Assert
@@ -199,7 +199,7 @@ def test_enum_hash_consistency(self):
         # Act
         email_hash1 = hash(NotificationTypes.EMAIL_NOTIFICATION)
         email_hash2 = hash(NotificationTypes.EMAIL_NOTIFICATION)
-        
+
         wpx_hash = hash(NotificationTypes.WPX_COMMENT)
         lifecycle_hash = hash(NotificationTypes.AGENT_LIFECYCLE)
 
@@ -227,4 +227,4 @@ def test_enum_comparison_with_none(self):
         # Act & Assert
         assert NotificationTypes.EMAIL_NOTIFICATION is not None
         assert NotificationTypes.EMAIL_NOTIFICATION != None
-        assert not (NotificationTypes.EMAIL_NOTIFICATION == None)
+        assert not (NotificationTypes.EMAIL_NOTIFICATION == None)