Skip to content

Commit 255bee3

Browse files
author
Johan Broberg
committed
Refactor send_chat_history_messages calls for improved readability
1 parent 1087cd5 commit 255bee3

File tree

2 files changed

+8
-24
lines changed

2 files changed

+8
-24
lines changed

tests/tooling/extensions/openai/test_e2e.py

Lines changed: 3 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -76,9 +76,7 @@ async def test_send_chat_history_e2e_success(self, service, mock_turn_context):
7676
# E2E-02
7777
@pytest.mark.asyncio
7878
@pytest.mark.unit
79-
async def test_send_chat_history_e2e_server_error(
80-
self, service, mock_turn_context
81-
):
79+
async def test_send_chat_history_e2e_server_error(self, service, mock_turn_context):
8280
"""Test full end-to-end flow with HTTP 500 error."""
8381
messages = [
8482
MockUserMessage(content="Hello"),
@@ -199,9 +197,7 @@ def capture_args(*args, **kwargs):
199197

200198
mock_send.side_effect = capture_args
201199

202-
await service.send_chat_history_messages(
203-
mock_turn_context, sample_openai_messages
204-
)
200+
await service.send_chat_history_messages(mock_turn_context, sample_openai_messages)
205201

206202
# Verify all messages are ChatHistoryMessage instances
207203
assert captured_messages is not None
@@ -343,9 +339,7 @@ def capture_post(*args, **kwargs):
343339
mock_session_instance.post.side_effect = capture_post
344340
mock_session_class.return_value.__aenter__.return_value = mock_session_instance
345341

346-
await service.send_chat_history_messages(
347-
mock_turn_context, sample_openai_messages
348-
)
342+
await service.send_chat_history_messages(mock_turn_context, sample_openai_messages)
349343

350344
# Verify headers
351345
assert captured_headers is not None

tests/tooling/extensions/openai/test_send_chat_history.py

Lines changed: 5 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -216,9 +216,7 @@ async def test_send_chat_history_messages_default_orchestrator_name(
216216
) as mock_send:
217217
mock_send.return_value = OperationResult.success()
218218

219-
await service.send_chat_history_messages(
220-
mock_turn_context, sample_openai_messages
221-
)
219+
await service.send_chat_history_messages(mock_turn_context, sample_openai_messages)
222220

223221
# Verify default orchestrator name
224222
call_args = mock_send.call_args
@@ -238,9 +236,7 @@ async def test_send_chat_history_messages_delegates_to_config_service(
238236
) as mock_send:
239237
mock_send.return_value = OperationResult.success()
240238

241-
await service.send_chat_history_messages(
242-
mock_turn_context, sample_openai_messages
243-
)
239+
await service.send_chat_history_messages(mock_turn_context, sample_openai_messages)
244240

245241
# Verify delegation
246242
mock_send.assert_called_once()
@@ -394,20 +390,14 @@ async def test_send_chat_history_messages_client_error(
394390
# EH-04
395391
@pytest.mark.asyncio
396392
@pytest.mark.unit
397-
async def test_send_chat_history_messages_conversion_error(
398-
self, service, mock_turn_context
399-
):
393+
async def test_send_chat_history_messages_conversion_error(self, service, mock_turn_context):
400394
"""Test send_chat_history_messages handles conversion errors gracefully."""
401395
sample_messages = [MockUserMessage(content="Hello")]
402396

403-
with patch.object(
404-
service, "_convert_openai_messages_to_chat_history"
405-
) as mock_convert:
397+
with patch.object(service, "_convert_openai_messages_to_chat_history") as mock_convert:
406398
mock_convert.side_effect = Exception("Conversion failed")
407399

408-
result = await service.send_chat_history_messages(
409-
mock_turn_context, sample_messages
410-
)
400+
result = await service.send_chat_history_messages(mock_turn_context, sample_messages)
411401

412402
assert result.succeeded is False
413403
assert len(result.errors) == 1

0 commit comments

Comments
 (0)