remove unused tests

Author: nikhilc-microsoft

tests/observability/core/test_baggage_builder.py

@@ -247,52 +247,6 @@ def test_set_pairs_accepts_dict_and_iterable(self):
             self.assertIsNone(baggage_contents.get(GEN_AI_CALLER_ID_KEY))
             self.assertIsNone(baggage_contents.get(HIRING_MANAGER_ID_KEY))
 
-    def test_from_turn_context_delegates_and_merges(self):
-        """from_turn_context should delegate to baggage_turn_context.from_turn_context and merge returned pairs."""
-        # Import the module to monkeypatch the symbol that BaggageBuilder closed over
-        from microsoft_agents_a365.observability.core.middleware import (
-            baggage_builder as tempBaggageBuilder,
-        )
-
-        original_fn = tempBaggageBuilder.from_turn_context
-
-        # Fake turn_context -> returns a mix of valid/ignored values
-        def fake_from_turn_context(turn_ctx: any):
-            self.assertEqual(turn_ctx, {"k": "v"})  # ensure pass-through of arg
-            return {
-                TENANT_ID_KEY: "tenant-ctx",
-                GEN_AI_AGENT_ID_KEY: "agent-ctx",
-                CORRELATION_ID_KEY: "  ",  # will be ignored
-                GEN_AI_AGENT_UPN_KEY: None,  # will be ignored
-                OPERATION_SOURCE_KEY: OperationSource.SDK.value,
-            }
-
-        try:
-            tempBaggageBuilder.from_turn_context = fake_from_turn_context
-
-            with (
-                BaggageBuilder()
-                .tenant_id("tenant-pre")  # will be overridden if same key is set later
-                .from_turn_context({"k": "v"})  # merges keys from fake function
-                .agent_auid("auid-pre")  # ensure pre-existing values remain
-                .build()
-            ):
-                baggage_contents = baggage.get_all()
-                # Values from turn_context
-                self.assertEqual(baggage_contents.get(TENANT_ID_KEY), "tenant-ctx")
-                self.assertEqual(baggage_contents.get(GEN_AI_AGENT_ID_KEY), "agent-ctx")
-                self.assertEqual(
-                    baggage_contents.get(OPERATION_SOURCE_KEY), OperationSource.SDK.value
-                )
-                # Pre-existing (non-overlapping) still present
-                self.assertEqual(baggage_contents.get(GEN_AI_AGENT_AUID_KEY), "auid-pre")
-                # Ignored values should not be present
-                self.assertIsNone(baggage_contents.get(CORRELATION_ID_KEY))
-                self.assertIsNone(baggage_contents.get(GEN_AI_AGENT_UPN_KEY))
-        finally:
-            # Restore original
-            tempBaggageBuilder.from_turn_context = original_fn
-
     def test_source_metadata_name_method(self):
         """Test deprecated source_metadata_name method - should delegate to channel_name."""
         # Should exist and be callable

tests/observability/core/test_turn_context_baggage.py

@@ -44,44 +44,59 @@ async def test_register_and_retrieve_token_success(
     expected_token = "mock-token-xyz"
     scopes = ["https://example.com/.default"]
 
-    # Setup mock
     mock_authorization.exchange_token.return_value = expected_token
 
-    # Create struct with default auth handler
     token_struct = AgenticTokenStruct(
         authorization=mock_authorization,
         turn_context=mock_turn_context,
     )
     assert token_struct.auth_handler_name == "AGENTIC"
 
-    # Register
     token_cache.register_observability(
         agent_id=agent_id,
         tenant_id=tenant_id,
         token_generator=token_struct,
         observability_scopes=scopes,
     )
 
-    # Retrieve token
     token = await token_cache.get_observability_token(agent_id, tenant_id)
-
     assert token == expected_token
-    mock_authorization.exchange_token.assert_called_once_with(
-        context=mock_turn_context,
-        scopes=scopes,
-        auth_handler_id="AGENTIC",
-    )
 
 
 @pytest.mark.parametrize(
     "agent_id,tenant_id,token_generator,error_type,error_match",
     [
         ("", "tenant-456", "valid", ValueError, "agent_id cannot be None or whitespace"),
-        ("agent-123", None, "valid", ValueError, "tenant_id cannot be None or whitespace"),
         ("agent-123", "tenant-456", None, TypeError, "token_generator cannot be None"),
     ],
 )
-@pytest.mark.asyncio
+def test_register_observability_validation(
+    token_cache,
+    mock_authorization,
+    mock_turn_context,
+    agent_id,
+    tenant_id,
+    token_generator,
+    error_type,
+    error_match,
+):
+    """Test that registration validates inputs and raises appropriate errors."""
+    struct = None
+    if token_generator == "valid":
+        struct = AgenticTokenStruct(
+            authorization=mock_authorization,
+            turn_context=mock_turn_context,
+        )
+
+    with pytest.raises(error_type, match=error_match):
+        token_cache.register_observability(
+            agent_id=agent_id,
+            tenant_id=tenant_id,
+            token_generator=struct,
+            observability_scopes=["scope"],
+        )
+
+
 def test_thread_safety(token_cache, mock_authorization, mock_turn_context):
     """Test that cache is thread-safe with concurrent registrations."""
     import threading