Update ObservabilityHostingManager.configure to use ChannelAdapter type and require non-None params

- Replace _AdapterLike protocol with actual ChannelAdapter from microsoft_agents.hosting.core
- Make adapter and options required (non-optional) parameters
- Raise TypeError if either is None
- Update tests to match new contract

Co-authored-by: nikhilNava <211831449+nikhilNava@users.noreply.github.com>

Author: Copilot

libraries/microsoft-agents-a365-observability-hosting/microsoft_agents_a365/observability/hosting/middleware/observability_hosting_manager.py

@@ -7,22 +7,15 @@
 
 import logging
 from dataclasses import dataclass
-from typing import Protocol
 
-from microsoft_agents.hosting.core import Middleware
+from microsoft_agents.hosting.core import ChannelAdapter
 
 from .baggage_middleware import BaggageMiddleware
 from .output_logging_middleware import OutputLoggingMiddleware
 
 logger = logging.getLogger(__name__)
 
 
-class _AdapterLike(Protocol):
-    """Protocol for adapter objects that support middleware registration."""
-
-    def use(self, middleware: Middleware) -> object: ...
-
-
 @dataclass
 class ObservabilityHostingOptions:
     """Configuration options for the hosting observability layer."""
@@ -53,20 +46,28 @@ def __init__(self) -> None:
     @classmethod
     def configure(
         cls,
-        adapter: _AdapterLike | None = None,
-        options: ObservabilityHostingOptions | None = None,
+        adapter: ChannelAdapter,
+        options: ObservabilityHostingOptions,
     ) -> ObservabilityHostingManager:
         """Configure the singleton instance and register middleware on the adapter.
 
         Subsequent calls after the first are no-ops and return the existing instance.
 
         Args:
-            adapter: An adapter that supports ``.use()`` for middleware registration.
-            options: Configuration options. Defaults are used when ``None``.
+            adapter: The channel adapter to register middleware on.
+            options: Configuration options controlling which middleware to enable.
 
         Returns:
             The singleton :class:`ObservabilityHostingManager` instance.
+
+        Raises:
+            TypeError: If *adapter* or *options* is ``None``.
         """
+        if adapter is None:
+            raise TypeError("adapter must not be None")
+        if options is None:
+            raise TypeError("options must not be None")
+
         if cls._instance is not None:
             logger.warning(
                 "[ObservabilityHostingManager] Already configured. "
@@ -76,26 +77,19 @@ def configure(
 
         instance = cls()
 
-        if adapter is not None:
-            opts = options or ObservabilityHostingOptions()
+        if options.enable_baggage:
+            adapter.use(BaggageMiddleware())
+            logger.info("[ObservabilityHostingManager] BaggageMiddleware registered.")
 
-            if opts.enable_baggage:
-                adapter.use(BaggageMiddleware())
-                logger.info("[ObservabilityHostingManager] BaggageMiddleware registered.")
+        if options.enable_output_logging:
+            adapter.use(OutputLoggingMiddleware())
+            logger.info("[ObservabilityHostingManager] OutputLoggingMiddleware registered.")
 
-            if opts.enable_output_logging:
-                adapter.use(OutputLoggingMiddleware())
-                logger.info("[ObservabilityHostingManager] OutputLoggingMiddleware registered.")
-
-            logger.info(
-                "[ObservabilityHostingManager] Configured. Baggage: %s, OutputLogging: %s.",
-                opts.enable_baggage,
-                opts.enable_output_logging,
-            )
-        else:
-            logger.warning(
-                "[ObservabilityHostingManager] No adapter provided. No middleware registered."
-            )
+        logger.info(
+            "[ObservabilityHostingManager] Configured. Baggage: %s, OutputLogging: %s.",
+            options.enable_baggage,
+            options.enable_output_logging,
+        )
 
         cls._instance = instance
         return instance

tests/observability/hosting/middleware/test_observability_hosting_manager.py

@@ -27,22 +27,23 @@ def _reset_singleton():
 def test_configure_returns_instance():
     """configure() should return an ObservabilityHostingManager instance."""
     adapter = MagicMock()
-    instance = ObservabilityHostingManager.configure(adapter)
+    instance = ObservabilityHostingManager.configure(adapter, ObservabilityHostingOptions())
     assert isinstance(instance, ObservabilityHostingManager)
 
 
 def test_configure_is_singleton():
     """Subsequent configure() calls should return the same instance."""
     adapter = MagicMock()
-    first = ObservabilityHostingManager.configure(adapter)
-    second = ObservabilityHostingManager.configure(adapter)
+    options = ObservabilityHostingOptions()
+    first = ObservabilityHostingManager.configure(adapter, options)
+    second = ObservabilityHostingManager.configure(adapter, options)
     assert first is second
 
 
 def test_configure_registers_baggage_middleware_by_default():
     """By default, BaggageMiddleware should be registered."""
     adapter = MagicMock()
-    ObservabilityHostingManager.configure(adapter)
+    ObservabilityHostingManager.configure(adapter, ObservabilityHostingOptions())
 
     # The adapter.use should have been called once (only BaggageMiddleware by default)
     assert adapter.use.call_count == 1
@@ -82,16 +83,14 @@ def test_configure_disables_all():
     adapter.use.assert_not_called()
 
 
-def test_configure_no_adapter():
-    """When no adapter is provided, no middleware should be registered."""
-    instance = ObservabilityHostingManager.configure()
-    assert isinstance(instance, ObservabilityHostingManager)
+def test_configure_raises_on_none_adapter():
+    """configure() should raise TypeError when adapter is None."""
+    with pytest.raises(TypeError, match="adapter must not be None"):
+        ObservabilityHostingManager.configure(None, ObservabilityHostingOptions())
 
 
-def test_configure_no_adapter_subsequent_call_ignored():
-    """Subsequent calls after no-adapter configure should still be no-ops."""
-    first = ObservabilityHostingManager.configure()
+def test_configure_raises_on_none_options():
+    """configure() should raise TypeError when options is None."""
     adapter = MagicMock()
-    second = ObservabilityHostingManager.configure(adapter)
-    assert first is second
-    adapter.use.assert_not_called()
+    with pytest.raises(TypeError, match="options must not be None"):
+        ObservabilityHostingManager.configure(adapter, None)