fix

Author: mrunalhirve128

libraries/microsoft-agents-a365-tooling-extensions-agentframework/microsoft_agents_a365/tooling/extensions/agentframework/services/__init__.py

@@ -12,4 +12,4 @@
 
 __all__ = [
     "McpToolRegistrationService",
-]
+]

libraries/microsoft-agents-a365-tooling-extensions-agentframework/microsoft_agents_a365/tooling/extensions/agentframework/services/mcp_tool_registration_service.py

@@ -11,7 +11,6 @@
 from microsoft_agents_a365.tooling.services.mcp_tool_server_configuration_service import (
     McpToolServerConfigurationService,
 )
-from microsoft_agents_a365.tooling.utils.utility import get_ppapi_token_scope
 from microsoft_agents_a365.tooling.utils.constants import Constants
 
 
@@ -64,7 +63,9 @@ async def add_tool_servers_to_agent(
             ChatAgent instance with MCP tools registered, or None if creation failed
         """
         try:
-            self._logger.info(f"Listing MCP tool servers for agent {agent_user_id} in environment {environment_id}")
+            self._logger.info(
+                f"Listing MCP tool servers for agent {agent_user_id} in environment {environment_id}"
+            )
 
             # Get MCP server configurations
             server_configs = await self._mcp_server_configuration_service.list_tool_servers(
@@ -81,39 +82,45 @@ async def add_tool_servers_to_agent(
             # Add MCP plugins for each server config
             for config in server_configs:
                 try:
-                    server_url = getattr(config, 'server_url', None) or getattr(config, 'mcp_server_unique_name', None)
+                    server_url = getattr(config, "server_url", None) or getattr(
+                        config, "mcp_server_unique_name", None
+                    )
                     if not server_url:
                         self._logger.warning(f"MCP server config missing server_url: {config}")
                         continue
-                    
+
                     # Prepare auth headers
                     headers = {}
                     if auth_token:
-                        headers[Constants.Headers.AUTHORIZATION] = f"{Constants.Headers.BEARER_PREFIX} {auth_token}"
+                        headers[Constants.Headers.AUTHORIZATION] = (
+                            f"{Constants.Headers.BEARER_PREFIX} {auth_token}"
+                        )
                     if environment_id:
                         headers[Constants.Headers.ENVIRONMENT_ID] = environment_id
-                    
-                    server_name = getattr(config, 'mcp_server_name', 'Unknown')
-                    
+
+                    server_name = getattr(config, "mcp_server_name", "Unknown")
+
                     # Create and configure MCP plugin
                     mcp_tools = MCPStreamableHTTPTool(
                         name=server_name,
                         url=server_url,
                         headers=headers,
-                        description=f"MCP tools from {server_name}"
+                        description=f"MCP tools from {server_name}",
                     )
-                    
+
                     # Let Agent Framework handle the connection automatically
                     self._logger.info(f"Created MCP plugin for '{server_name}' at {server_url}")
-                    
+
                     all_tools.append(mcp_tools)
                     self._connected_servers.append(mcp_tools)
-                    
+
                     self._logger.info(f"Added MCP plugin '{server_name}' to agent tools")
-                    
+
                 except Exception as tool_ex:
-                    server_name = getattr(config, 'mcp_server_name', 'Unknown')
-                    self._logger.warning(f"Failed to create MCP plugin for {server_name}: {tool_ex}")
+                    server_name = getattr(config, "mcp_server_name", "Unknown")
+                    self._logger.warning(
+                        f"Failed to create MCP plugin for {server_name}: {tool_ex}"
+                    )
                     continue
 
             # Create the ChatAgent
@@ -135,10 +142,10 @@ async def cleanup(self):
         try:
             for plugin in self._connected_servers:
                 try:
-                    if hasattr(plugin, 'close'):
+                    if hasattr(plugin, "close"):
                         await plugin.close()
                 except Exception as cleanup_ex:
                     self._logger.debug(f"Error during cleanup: {cleanup_ex}")
             self._connected_servers.clear()
         except Exception as ex:
-            self._logger.debug(f"Error during service cleanup: {ex}")
+            self._logger.debug(f"Error during service cleanup: {ex}")

libraries/microsoft-agents-a365-tooling-extensions-openai/microsoft_agents_a365/tooling/extensions/openai/mcp_tool_registration_service.py

@@ -80,7 +80,9 @@ async def add_tool_servers_to_agent(
         # Get MCP server configurations from the configuration service
         # mcp_server_configs = []
         # TODO: radevika: Update once the common project is merged.
-        self._logger.info(f"Listing MCP tool servers for agent {agent_user_id} in environment {environment_id}")
+        self._logger.info(
+            f"Listing MCP tool servers for agent {agent_user_id} in environment {environment_id}"
+        )
         mcp_server_configs = await self.config_service.list_tool_servers(
             agent_user_id=agent_user_id, environment_id=environment_id, auth_token=auth_token
         )
@@ -146,11 +148,15 @@ async def add_tool_servers_to_agent(
                     connected_servers.append(mcp_server)
 
                     existing_server_urls.append(si.url)
-                    self._logger.info(f"Successfully connected to MCP server '{si.name}' at {si.url}")
+                    self._logger.info(
+                        f"Successfully connected to MCP server '{si.name}' at {si.url}"
+                    )
 
                 except Exception as e:
                     # Log the error but continue with other servers
-                    self._logger.warning(f"Failed to connect to MCP server {si.name} at {si.url}: {e}")
+                    self._logger.warning(
+                        f"Failed to connect to MCP server {si.name} at {si.url}: {e}"
+                    )
                     continue
 
         # If we have new servers, we need to recreate the agent
@@ -184,7 +190,9 @@ async def add_tool_servers_to_agent(
                     self._connected_servers = []
                 self._connected_servers.extend(connected_servers)
 
-                self._logger.info(f"Agent recreated successfully with {len(all_mcp_servers)} total MCP servers")
+                self._logger.info(
+                    f"Agent recreated successfully with {len(all_mcp_servers)} total MCP servers"
+                )
                 # Return the new agent (caller needs to replace the old one)
                 return new_agent
 

libraries/microsoft-agents-a365-tooling-extensions-semantickernel/microsoft_agents_a365/tooling/extensions/semantickernel/services/mcp_tool_registration_service.py

@@ -49,7 +49,9 @@ def __init__(
             logger: Logger instance for logging operations.
         """
         self._logger = logger or logging.getLogger(self.__class__.__name__)
-        self._mcp_server_configuration_service = McpToolServerConfigurationService(logger=self._logger)
+        self._mcp_server_configuration_service = McpToolServerConfigurationService(
+            logger=self._logger
+        )
 
         # Store connected plugins to keep them alive
         self._connected_plugins = []