Skip to content

Commit f5e9e8d

Browse files
committed
Removing TOOLS_MODE
1 parent a33e81a commit f5e9e8d

3 files changed

Lines changed: 6 additions & 77 deletions

File tree

libraries/microsoft-agents-a365-tooling-extensions-semantickernel/microsoft_agents_a365/tooling/extensions/semantickernel/services/mcp_tool_registration_service.py

Lines changed: 5 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@
2323
from microsoft_agents_a365.tooling.models.mcp_server_config import MCPServerConfig
2424
from microsoft_agents_a365.tooling.utils.constants import Constants
2525
from microsoft_agents_a365.tooling.utils.utility import (
26-
get_tools_mode,
2726
get_mcp_platform_authentication_scope,
2827
)
2928

@@ -112,30 +111,17 @@ async def add_tool_servers_to_agent(
112111
)
113112
self._logger.info(f"🔧 Adding MCP tools from {len(servers)} servers")
114113

115-
# Get tools mode
116-
tools_mode = get_tools_mode()
117-
118114
# Process each server (matching C# foreach pattern)
119115
for server in servers:
120116
try:
121-
if tools_mode == "HardCodedTools":
122-
await self._add_hardcoded_tools_for_server(kernel, server)
123-
continue
124-
125-
headers = {}
126-
127-
if tools_mode == "MockMCPServer":
128-
if mock_auth_header := os.getenv("MOCK_MCP_AUTHORIZATION"):
129-
headers[Constants.Headers.AUTHORIZATION] = mock_auth_header
130-
else:
131-
headers = {
132-
Constants.Headers.AUTHORIZATION: f"{Constants.Headers.BEARER_PREFIX} {auth_token}",
133-
}
117+
headers = {
118+
Constants.Headers.AUTHORIZATION: f"{Constants.Headers.BEARER_PREFIX} {auth_token}",
119+
}
134120

135121
plugin = MCPStreamableHttpPlugin(
136122
name=server.mcp_server_name,
137123
url=server.mcp_server_unique_name,
138-
headers=headers or None,
124+
headers=headers,
139125
)
140126

141127
# Connect the plugin
@@ -151,7 +137,7 @@ async def add_tool_servers_to_agent(
151137
self._connected_plugins.append(plugin)
152138

153139
self._logger.info(
154-
f"✅ Connected and added MCP plugin ({tools_mode}) for: {server.mcp_server_name}"
140+
f"✅ Connected and added MCP plugin for: {server.mcp_server_name}"
155141
)
156142

157143
except Exception as e:
@@ -172,29 +158,6 @@ def _validate_inputs(self, kernel: Any, agentic_app_id: str, auth_token: str) ->
172158
if not auth_token or not auth_token.strip():
173159
raise ValueError("auth_token cannot be null or empty")
174160

175-
async def _add_hardcoded_tools_for_server(self, kernel: Any, server: MCPServerConfig) -> None:
176-
"""Add hardcoded tools for a specific server (equivalent to C# hardcoded tool logic)."""
177-
server_name = server.mcp_server_name
178-
179-
if server_name.lower() == "mcp_mailtools":
180-
# TODO: Implement hardcoded mail tools
181-
# kernel.plugins.add(KernelPluginFactory.create_from_type(HardCodedMailTools, server.mcp_server_name, self._service_provider))
182-
self._logger.info(f"Adding hardcoded mail tools for {server_name}")
183-
elif server_name.lower() == "mcp_sharepointtools":
184-
# TODO: Implement hardcoded SharePoint tools
185-
# kernel.plugins.add(KernelPluginFactory.create_from_type(HardCodedSharePointTools, server.mcp_server_name, self._service_provider))
186-
self._logger.info(f"Adding hardcoded SharePoint tools for {server_name}")
187-
elif server_name.lower() == "onedrivemcpserver":
188-
# TODO: Implement hardcoded OneDrive tools
189-
# kernel.plugins.add(KernelPluginFactory.create_from_type(HardCodedOneDriveTools, server.mcp_server_name, self._service_provider))
190-
self._logger.info(f"Adding hardcoded OneDrive tools for {server_name}")
191-
elif server_name.lower() == "wordmcpserver":
192-
# TODO: Implement hardcoded Word tools
193-
# kernel.plugins.add(KernelPluginFactory.create_from_type(HardCodedWordTools, server.mcp_server_name, self._service_provider))
194-
self._logger.info(f"Adding hardcoded Word tools for {server_name}")
195-
else:
196-
self._logger.warning(f"No hardcoded tools available for server: {server_name}")
197-
198161
# ============================================================================
199162
# Private Methods - Kernel Function Creation
200163
# ============================================================================

libraries/microsoft-agents-a365-tooling/microsoft_agents_a365/tooling/utils/__init__.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
get_tooling_gateway_for_digital_worker,
1111
get_mcp_base_url,
1212
build_mcp_server_url,
13-
get_tools_mode,
1413
get_mcp_platform_authentication_scope,
1514
)
1615

@@ -19,6 +18,5 @@
1918
"get_tooling_gateway_for_digital_worker",
2019
"get_mcp_base_url",
2120
"build_mcp_server_url",
22-
"get_tools_mode",
2321
"get_mcp_platform_authentication_scope",
2422
]

libraries/microsoft-agents-a365-tooling/microsoft_agents_a365/tooling/utils/utility.py

Lines changed: 1 addition & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -5,14 +5,6 @@
55
"""
66

77
import os
8-
from enum import Enum
9-
10-
11-
class ToolsMode(Enum):
12-
"""Enumeration for different tools modes."""
13-
14-
MOCK_MCP_SERVER = "MockMCPServer"
15-
MCP_PLATFORM = "MCPPlatform"
168

179

1810
# Constants for base URLs
@@ -43,13 +35,6 @@ def get_mcp_base_url() -> str:
4335
Returns:
4436
str: The base URL for MCP servers.
4537
"""
46-
environment = _get_current_environment().lower()
47-
48-
if environment == "development":
49-
tools_mode = get_tools_mode()
50-
if tools_mode == ToolsMode.MOCK_MCP_SERVER:
51-
return os.getenv("MOCK_MCP_SERVER_URL", "http://localhost:5309/mcp-mock/agents/servers")
52-
5338
return f"{_get_mcp_platform_base_url()}/agents/servers"
5439

5540

@@ -91,30 +76,13 @@ def _get_mcp_platform_base_url() -> str:
9176
return MCP_PLATFORM_PROD_BASE_URL
9277

9378

94-
def get_tools_mode() -> ToolsMode:
95-
"""
96-
Gets the tools mode for the application.
97-
98-
Returns:
99-
ToolsMode: The tools mode enum value.
100-
"""
101-
tools_mode = os.getenv("TOOLS_MODE", "MCPPlatform").lower()
102-
103-
if tools_mode == "mockmcpserver":
104-
return ToolsMode.MOCK_MCP_SERVER
105-
else:
106-
return ToolsMode.MCP_PLATFORM
107-
108-
10979
def get_mcp_platform_authentication_scope():
11080
"""
111-
Gets the MCP platform authentication scope based on the current environment.
81+
Gets the MCP platform authentication scope.
11282
11383
Returns:
11484
list: A list containing the appropriate MCP platform authentication scope.
11585
"""
116-
environment = _get_current_environment().lower()
117-
11886
envScope = os.getenv("MCP_PLATFORM_AUTHENTICATION_SCOPE", "")
11987

12088
if envScope:

0 commit comments

Comments
 (0)