Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Workspace Owners to add multiple users and assign WorkspaceResearcher role #4169

Open
Tracked by #2045
marrobi opened this issue Dec 5, 2024 · 5 comments · May be fixed by #4337
Open
Tracked by #2045

Enable Workspace Owners to add multiple users and assign WorkspaceResearcher role #4169

marrobi opened this issue Dec 5, 2024 · 5 comments · May be fixed by #4337
Assignees
Labels
story Stories are the smallest unit of work to be done for a project.

Comments

@marrobi
Copy link
Member

marrobi commented Dec 5, 2024

From the workspace user interface a workspaceowner can assign users to the workspace researcher role. The workspaceowner must also be able to both add and remove users. This will require changes to both the UI and API.

Need to consider the adding of groups.

Need option to disable user management APIs (don't add APIs to the router)

@tim-p-allen tim-p-allen added the story Stories are the smallest unit of work to be done for a project. label Dec 5, 2024
@marrobi marrobi changed the title I can add multiple users and assign WorkspaceResearcher role Enable Workspace Owners to add multiple users and assign WorkspaceResearcher role Dec 11, 2024
@fortunkam
Copy link

Thoughts on this...

  1. Would you want the workspace owner to allocate Airlock manager and other owners (only the workspace researcher is specified above)?
  2. Is a config setting good enough to disable the APIs and UI User Management elements?
  3. If User Management is disabled, do we still want to allow the viewing of assigned users to a workspace or should we just hide the tab?

@TonyWildish-BH
Copy link
Contributor

From our perspective, we do not want Workspace Admins or Researchers to be able to allocate people to roles in their workspaces.

Having them add new researchers who haven't been vetted is a violation of the Safe People principle. Allowing them to allocate Airlock Managers would invalidate the entire concept of the TRE, since they'd be marking their own homework.

The only potentially useful functions for our environment would be:

  1. Allowing Workspace Admins to shuffle their existing users between the roles of Researcher and Admin. Useful when a Researcher needs more access, or when an Admin is leaving a running project.
  2. Allowing Workspace Admins to remove someone from the project entirely, but not to then add them, or anyone else, back in.

Anything else would be bad news for us, so please make sure that any such features are configurable, so we can disable them.

@marrobi
Copy link
Member Author

marrobi commented Feb 6, 2025

@fortunkam keep it to TRE Admins for now, we will need to revisit RBAC across the TRE at some point as use cases are getting more complex. #3826

Config setting for API and UI sounds like a good idea. We are also likely to do one for cost reporting as per #4318

If can hide the whole user section, as we can get more granular using RBAC down the line.

Thank you!

@fortunkam
Copy link

This is the current WIP.

Image

Image

Will make sure the assign/de-assign is only available to TRE admins and only if the flag is set.

@marrobi
Copy link
Member Author

marrobi commented Feb 6, 2025

This is the current WIP.

Image

Image

Will make sure the assign/de-assign is only available to TRE admins and only if the flag is set.

Excellent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
story Stories are the smallest unit of work to be done for a project.
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

4 participants