Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings due to @qiwi/npm-registry-client used in utils package #543

Open
kirtan-desai opened this issue Oct 5, 2022 · 5 comments
Open

Comments

@kirtan-desai
Copy link

What is the purpose of using npm-registry-client? Is there any plan to deprecate its usage? The use of request library in @qiwi/npm-registry-client is causing warnings upstream.

@kamontat
Copy link

kamontat commented Jan 1, 2024

I would like to follow up on this as well.
@sandersn @jakebailey @andrewbranch

@sandersn
Copy link
Member

sandersn commented Jan 3, 2024

npm-registry-client is used for publishing and updating tags. It's not needed for dtslint, dtslint-runner or eslint-plugin, the parts that run in CI.

  1. What are the warnings? Can you link to one?
  2. What is 'upstream'? Are you depending on rules from @definitelytyped/eslint-plugin?
  3. Is there an alternative to use? I remember somebody mentioning it but we were in middle of lots of other work on dt-tools at the time.

@jakebailey
Copy link
Member

It's a dep of the util package since it's used both in the publisher and in retag.

I've been meaning to send a PR to switch everything over to pacote or libnpmpublish by reviving #472 which is conflicted (but didn't finish the rebase before the holidays)

@jakebailey
Copy link
Member

I do think we should make some sort of "internal utils" package to hold shared code for our non published packages, as that'd minimize these sorts of problems. (Then again the only people that should see this message are those depending on our packages outside of DT which we don't yet officially say is a good idea)

@kamontat
Copy link

kamontat commented Jan 4, 2024

@jakebailey I'm not sure what the original problem @kirtan-desai was.

Describe

For me, @qiwi/npm-registry-client contains 2 problem dependencies: request which contains tough-cookie. Both dependencies contains vulnerability (here and here). Even though it might not effect but I would like to mitigate potential issues as well as @qiwi/npm-registry-client didn't release any new version in past 3 years.

How

I currently use @definitelytyped/eslint-plugin to lint internal @types packages. and it use utils internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants