Currently extra folder or incorrect XML info in CustomDiagnostics might cause an exception

[gambit9009]

Not that many people would add stuff here on their own, but for devs working on adding stuff, it can be a pain. In DiagFactory.cs we run GetCustomDiagnostics. In there we are just getting a directory list of what folders are in "\CustomDiagnostics". Then in each folder we are looking for a \CustomDiag.xml. We compare these with what we find in CustomDiagnostic_Template.xml. There is not a TRY/CATCH in this whole DiagFactory.cs. Same with DiagTreeMgr where we call PopulateTree.

So any issues we hit falls all the way out to the frmDiagManager_Load function which just prints the exception without any context. This causes all the checkbox to not be added. It has been hard to troubleshoot not knowing where the failure occurred. Better try catch would help

[gambit9009]

Realized the extra folder issue can come up if you run in retail or debug folder and your extra folder gets created in those build folders. So when the DiagFactory is searching the CustomDiagnostics folder for subfolders, it is the current running directory and not the source directory where we are creating those in the project.

[gambit9009]

Exception when I create a test folder under the CustomDiagnostics and try to start DiagManager...

DiagManager still loads after I OK. But it doesn't build the rest of the screen with all the radio button and checkboxes.

We looked into closing after this error but the way it is coded doesn't let that easily work.

The fix is to just delete that empty folder.