Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove MockLogger from public API surface #23039

Open
alexvy86 opened this issue Nov 8, 2024 · 0 comments
Open

Remove MockLogger from public API surface #23039

alexvy86 opened this issue Nov 8, 2024 · 0 comments
Assignees
Labels
api deprecation Changes to a deprecated API breaking change This PR or issue would introduce a breaking change triage

Comments

@alexvy86
Copy link
Contributor

alexvy86 commented Nov 8, 2024

Removed APIs

  • The (legacy+alpha) MockLogger class in @fluidframework/telemetry-utils

Context

The MockLogger class exposed in the legacy+alpha API surface of the @fluidframework/telemetry-utils package was deprecated in June 2024. This class was intended for testing, so we don't expect anybody to have been using it in production code.

We did the removal in #23010 but reverted it in #23035 because it hadn't been announced previously as part of the breaking changes in 2.10.

Approach

No replacement will be provided. Consumers were encouraged to just reimplement it if necessary.

Dependencies

N/A

Compatibility Concerns

N/A

Phases

The only pending step is removing the class from the public API surface.

Expected Timeline

Expected to be removed in FF 2.20.0.

Open Questions

N/A

@alexvy86 alexvy86 added api deprecation Changes to a deprecated API breaking change This PR or issue would introduce a breaking change labels Nov 8, 2024
@alexvy86 alexvy86 self-assigned this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api deprecation Changes to a deprecated API breaking change This PR or issue would introduce a breaking change triage
Projects
None yet
Development

No branches or pull requests

1 participant