Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some lint rules are not working #9093

Closed
markfields opened this issue Feb 10, 2022 · 6 comments
Closed

Some lint rules are not working #9093

markfields opened this issue Feb 10, 2022 · 6 comments
Assignees
Labels
area: repo Repo related work triage
Milestone

Comments

@markfields
Copy link
Member

markfields commented Feb 10, 2022

This is probably a bug in eslint or a plugin, but I've noticed at least two rules that are not being enforced properly in the code. For these two I can paste in the "Incorrect" code examples from the docs and it builds just fine. They are both enabled in the eslint config, as far as I can tell.

typescript-eslint/promise-function-async.md at main · typescript-eslint/typescript-eslint (github.com)
typescript-eslint/strict-boolean-expressions.md at main · typescript-eslint/typescript-eslint (github.com)

@ghost ghost added the triage label Feb 10, 2022
@markfields markfields added this to the March 2022 milestone Feb 10, 2022
@markfields
Copy link
Member Author

Assigning to March milestone but ideally we can get to the bottom of this sooner than that.

@markfields
Copy link
Member Author

Closing this - I was looking at eslint7.js, which is no longer used. These rules are just not enabled. Following up in #9082

@ChumpChief ChumpChief self-assigned this Feb 11, 2022
@ChumpChief ChumpChief reopened this Feb 11, 2022
@ChumpChief
Copy link
Contributor

I'll use this to track getting the rules from eslint7 back on again via some approach.

@tylerbutler
Copy link
Member

@ChumpChief Was this addressed by #9135? Are there other rules that need to be re-enabled other than unbound-method (#9082)?

@ChumpChief
Copy link
Contributor

I'd probably close this one since based on @markfields description I think he was just expecting eslint7 to be enabled. Maybe open a new epic to survey our rules, add missing rules that are worth having, and unify them.

@tylerbutler
Copy link
Member

The remaining work is tracked by #9501, so closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: repo Repo related work triage
Projects
None yet
Development

No branches or pull requests

3 participants