Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What happens to missing data during training when use_missing=False? #6819

Open
hsorsky opened this issue Feb 7, 2025 · 0 comments
Open
Labels

Comments

@hsorsky
Copy link
Contributor

hsorsky commented Feb 7, 2025

Similar to #2921, but regarding what happens if we have use_missing=False.

Apologies for opening a new issue, but that issue is "locked and limited to collaborators.". If I understood what disabling use_missing=False actually did, I'd be happy to try to improve the docs around it, but at the moment I do not understand it.

I am not well versed with C++, but from

LightGBM/src/io/bin.cpp

Lines 322 to 323 in 2db0b25

if (!use_missing) {
missing_type_ = MissingType::None;

and
if (std::isnan(fval) && missing_type != MissingType::NaN) {
fval = 0.0f;
}

it looks like, even if we set zero_as_missing=False we'd still treat missing values like zeros?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants