Skip to content

Conversation

@Bashamega
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 5, 2025

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

// The corresponding standardized property is not supported by
// anyone as of 2024-10.
property webkitLineClamp deprecated=#false
property webkitLineClamp supported=#true
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A better way would be to remove the field through removals, although it's not supported yet. Maybe that should be the first step.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you share the syntax for it @saschanaz I can't imagine it

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like

removals {
  interface CSSStyleProperties {
    property webkitLineClamp deprecated=#null
  }
}

Or perhaps it's easier to keep using each property's own type, like deprecated="" and let it converted to null via the removal conversion function. Either way would be fine for me.

@Bashamega Bashamega requested a review from saschanaz December 7, 2025 04:10
@Bashamega
Copy link
Contributor Author

Yay @saschanaz
I can re-request your review
Can you please tell me the syntax for it?

@Bashamega
Copy link
Contributor Author

I have updated it @saschanaz
But now this is being logged
removedTypes.json has a redundant field events in {"events":{"event":null},"properties":{"property":{"webkitLineClamp":{"deprecated":null}}},"methods"

@Bashamega
Copy link
Contributor Author

Bashamega commented Dec 7, 2025

You can push directly Btw @saschanaz

@saschanaz
Copy link
Collaborator

LGTM

@github-actions github-actions bot merged commit 79b5a01 into microsoft:main Dec 7, 2025
6 checks passed
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2025

Merging because @saschanaz is a code-owner of all the changes - thanks!

@Bashamega Bashamega deleted the deprecated-string-only branch December 8, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants