add test code to agentops's tracer #324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ide the agentops' _trace_context_sync function.
ultmaster
reviewed
Nov 20, 2025
tests/tracer/test_agentops.py
Outdated
| ) | ||
|
|
||
| def otlp_traces_endpoint(self) -> str: | ||
| return "dump://" |
Contributor
There was a problem hiding this comment.
Are you sure this won't cause errors? How do you check whether the traces have been dumped?
Collaborator
Author
There was a problem hiding this comment.
Got it, added a mocked service.
ultmaster
reviewed
Nov 27, 2025
tests/tracer/test_agentops.py
Outdated
| from agentlightning.utils import otlp | ||
|
|
||
|
|
||
| class MockLightningStoreService: |
tests/tracer/test_agentops.py
Outdated
| tracer.teardown() | ||
|
|
||
|
|
||
| def test_agentops_trace_with_store_or_not(): |
Contributor
There was a problem hiding this comment.
use pytest.parametrize to split into three tests maybe.
Contributor
|
/ci |
|
🚀 CI Watcher for correlation id-3585196667-mihb45ca triggered by comment 3585196667
✅ All runs completed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add test code to expand the test code coverage to cover all paths inside the agentops' _trace_context_sync function.