Skip to content

use StringUtils in common-lang3#935

Merged
andxu merged 4 commits intodevelopfrom
andy-develop-stringutil
Dec 11, 2019
Merged

use StringUtils in common-lang3#935
andxu merged 4 commits intodevelopfrom
andy-develop-stringutil

Conversation

@andxu
Copy link
Copy Markdown
Contributor

@andxu andxu commented Dec 11, 2019

No description provided.

@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #935 into develop will increase coverage by 0.01%.
The diff coverage is 6.06%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop     #935      +/-   ##
=============================================
+ Coverage      42.54%   42.56%   +0.01%     
  Complexity       774      774              
=============================================
  Files            150      150              
  Lines           5427     5425       -2     
  Branches         769      769              
=============================================
  Hits            2309     2309              
+ Misses          2948     2946       -2     
  Partials         170      170
Impacted Files Coverage Δ Complexity Δ
...e/maven/queryer/MavenPluginQueryerDefaultImpl.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...webapp/handlers/artifact/ArtifactHandlerUtils.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...src/main/java/com/microsoft/azure/maven/Utils.java 74.35% <ø> (ø) 0 <0> (ø) ⬇️
...icrosoft/azure/maven/webapp/utils/WebAppUtils.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...azure/maven/spring/spring/SpringServiceClient.java 55.17% <ø> (ø) 6 <0> (ø) ⬇️
...a/com/microsoft/azure/maven/spring/DeployMojo.java 6.81% <ø> (ø) 5 <0> (ø) ⬇️
...m/microsoft/azure/maven/webapp/utils/XMLUtils.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...com/microsoft/azure/maven/function/DeployMojo.java 45.45% <ø> (ø) 17 <0> (ø) ⬇️
...ure/maven/webapp/parser/V2ConfigurationParser.java 0% <ø> (ø) 0 <0> (ø) ⬇️
...ueryer/MavenPluginQueryerBatchModeDefaultImpl.java 0% <ø> (ø) 0 <0> (ø) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eebcddc...2768453. Read the comment docs.

Copy link
Copy Markdown
Member

@Flanker32 Flanker32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@andxu andxu merged commit a82237a into develop Dec 11, 2019
@andxu andxu deleted the andy-develop-stringutil branch December 11, 2019 07:06
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 6.06061% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.56%. Comparing base (eebcddc) to head (2768453).
⚠️ Report is 4073 commits behind head on develop.

Files with missing lines Patch % Lines
...oft/azure/maven/spring/spring/SpringAppClient.java 0.00% 13 Missing ⚠️
.../com/microsoft/azure/maven/webapp/utils/Utils.java 0.00% 7 Missing ⚠️
...va/com/microsoft/azure/maven/function/AddMojo.java 33.33% 2 Missing and 2 partials ⚠️
...a/com/microsoft/azure/maven/webapp/ConfigMojo.java 0.00% 2 Missing ⚠️
...zure/maven/webapp/handlers/HandlerFactoryImpl.java 0.00% 2 Missing ⚠️
...re/maven/function/handlers/CommandHandlerImpl.java 0.00% 1 Missing ⚠️
...soft/azure/maven/function/utils/FunctionUtils.java 0.00% 1 Missing ⚠️
...crosoft/azure/maven/webapp/AbstractWebAppMojo.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##             develop     #935      +/-   ##
=============================================
+ Coverage      42.54%   42.56%   +0.01%     
  Complexity       774      774              
=============================================
  Files            150      150              
  Lines           5427     5425       -2     
  Branches         769      769              
=============================================
  Hits            2309     2309              
+ Misses          2948     2946       -2     
  Partials         170      170              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants