Support user defined auth method with configuration#975
Merged
Conversation
andxu
reviewed
Jan 3, 2020
azure-auth-helper/src/main/java/com/microsoft/azure/auth/AzureAuthHelper.java
Outdated
Show resolved
Hide resolved
andxu
reviewed
Jan 3, 2020
azure-maven-plugin-lib/src/main/java/com/microsoft/azure/maven/AbstractAzureMojo.java
Show resolved
Hide resolved
andxu
reviewed
Jan 3, 2020
| @@ -67,7 +51,6 @@ public static Azure getAzureClient(AuthConfiguration auth, String subscriptionId | |||
| Log.info(String.format(SUBSCRIPTION_TEMPLATE, subscription.displayName(), subscription.subscriptionId())); | |||
Contributor
There was a problem hiding this comment.
move this piece of code to abstractazuremojo and record auth type, subscription id(in another PR)
andxu
reviewed
Jan 3, 2020
azure-auth-helper/src/main/java/com/microsoft/azure/auth/configuration/AuthType.java
Outdated
Show resolved
Hide resolved
andxu
reviewed
Jan 3, 2020
| for (final AuthType authType : AUTH_ORDER) { | ||
| try { | ||
| result = authType.getAzureToken(authConfiguration, azureEnvironment); | ||
| if (result != null) { |
Contributor
There was a problem hiding this comment.
can you call a light azure api to verify the auth credential?
Codecov Report
@@ Coverage Diff @@
## develop #975 +/- ##
=============================================
- Coverage 41.65% 41.42% -0.23%
- Complexity 778 780 +2
=============================================
Files 155 155
Lines 5587 5620 +33
Branches 784 786 +2
=============================================
+ Hits 2327 2328 +1
- Misses 3091 3124 +33
+ Partials 169 168 -1
Continue to review full report at Codecov.
|
andxu
reviewed
Jan 6, 2020
azure-auth-helper/src/main/java/com/microsoft/azure/auth/configuration/AuthType.java
Outdated
Show resolved
Hide resolved
andxu
reviewed
Jan 6, 2020
azure-maven-plugin-lib/src/main/java/com/microsoft/azure/maven/AbstractAzureMojo.java
Outdated
Show resolved
Hide resolved
andxu
reviewed
Jan 6, 2020
| .filter(authTypeEnum -> StringUtils.equalsAnyIgnoreCase(authTypeEnum.name(), authType)) | ||
| .findFirst().orElse(null); | ||
| if (result == null) { | ||
| Log.warn(String.format(INVALID_AUTH_TYPE, authType, StringUtils.join(AuthType.values(), ", "))); |
andxu
approved these changes
Jan 6, 2020
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #975 +/- ##
=============================================
- Coverage 41.65% 41.42% -0.23%
- Complexity 778 780 +2
=============================================
Files 155 155
Lines 5587 5620 +33
Branches 784 786 +2
=============================================
+ Hits 2327 2328 +1
- Misses 3091 3124 +33
+ Partials 169 168 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support user defined auth method with configuration