Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker@2 reports target as unexpected property #479

Open
brsmyth opened this issue Jun 17, 2022 · 4 comments
Open

Docker@2 reports target as unexpected property #479

brsmyth opened this issue Jun 17, 2022 · 4 comments
Labels
accurate-yaml-validation Fidelity of matching YAML features Area: VsCodeExtension enhancement Small enhancement to existing functionality

Comments

@brsmyth
Copy link

brsmyth commented Jun 17, 2022

Consider a pipeline definition snippet like:

jobs:
- job: 
  container:
    image: mycontainer
    endpoint: container-reg
  steps:
  - task: Docker@2
    target: host
    inputs:
      command: build

The default tasks running in the job are to run in container mycontainer, but there are Docker@2 tasks that need to run on the host. The VS Code extension lists target as an unexpected property in the problems. Running the pipeline behaves as expected: the container build task is executed on the agent host.

@SvetlanaMaliugina SvetlanaMaliugina added enhancement Small enhancement to existing functionality and removed triage labels Jun 21, 2022
@winstliu winstliu added the accurate-yaml-validation Fidelity of matching YAML features label Jun 21, 2022
@winstliu
Copy link
Member

Thanks for reporting @brsmyth. Looks like this is an issue with the YAML schema we're getting back from ADO. I'll file an issue on them and link to it here when I do.

Documentation on the target property for reference: https://docs.microsoft.com/en-us/azure/devops/pipelines/process/tasks?view=azure-devops&tabs=yaml#step-target

@jdthorpe
Copy link

jdthorpe commented Jun 29, 2022

@50Wliu The same yaml schema has another error, which is that the command: pull raises this error even though "pull" is a valid value:

Value is not accepted. Valid values: "buildAndPush", "build", "push", "login", "logout", "start", "stop".

@winstliu
Copy link
Member

@jdthorpe Would you mind creating a new issue for that? I believe it should be easier to fix than this one :).

@winstliu
Copy link
Member

I'll file an issue on them and link to it here when I do.

Filed as https://developercommunity2.visualstudio.com/t/YAML-Schema-API-is-missing-target-proper/10085540.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accurate-yaml-validation Fidelity of matching YAML features Area: VsCodeExtension enhancement Small enhancement to existing functionality
Projects
None yet
Development

No branches or pull requests

4 participants