"no match response" button present in qna maker dialog when active learning is disabled

[asdkant-ey]

Version

4.11.0

Describe the bug

The "no match" button to be used when active learning is enabled is shown when active learning is NOT enabled

To Reproduce

Any bot using botbuilder.ai.qna.dialogs.QnAMakerDialog() will present a question's prompts plus the "None of the above." prompt.

Expected behavior

The "None of the above." prompt should not be present if the QnA KB does not have active learning enabled (or at least there should be a way to disable it)

Screenshots

This answer a number of prompts in the KB which are not the one added by the code in question

Additional context

The offending code lives in botbuilder.ai.qna.dialogs.QnAMakerDialog.__call_generate_answer(), which instantiates botbuilder.ai.qna.utils.QnACardBuilder. The method get_qna_prompts_card() has this particular piece of code:

        # Add No match text
        button_list.append(
            CardAction(
                value=card_no_match_text, type="imBack", title=card_no_match_text,
            )
        )

which should be controlled by some kind of switch when a QnACardBuilder object is instantiated.

[EricDahlvang]

Thank you for raising this @asdkant-ey This is the current behavior of all sdk language versions, so we've moved this to the overall SDK repos and we will triage this feature request for a future release.

@garypretty please help with prioritizing this feature request.

[garypretty]

@EricDahlvang I have marked this as a P1 for R12, based on my assumption that this fix should be minimal in terms of changes. If this is more complicated then we can revisit the priority vs other R12 commitments.

[garypretty]

Assigned to @cleemullins for assignment out to the team.

[asdkant-ey]

I've worked around the issue by monkeypatching QnACardBuilder.get_qna_prompts_card. It's an ugly hack but at the very least it works in the meantime (so long as I don't want to use active learning)

To do this, paste the code below to MonkeyPatch.py and follow the instructions in the comment:

from botbuilder.core import CardFactory
from botbuilder.schema import Activity, ActivityTypes, CardAction, HeroCard
from botbuilder.ai.qna.models import QueryResult
from botbuilder.ai.qna.utils import QnACardBuilder

"""monkey patch using this snippet:
        from MonkeyPatch import QnACardBuilderFix
        from botbuilder.ai.qna.utils import QnACardBuilder
        QnACardBuilder.get_qna_prompts_card = QnACardBuilderFix.get_qna_prompts_card
"""

class QnACardBuilderFix(QnACardBuilder):
    @staticmethod
    def get_qna_prompts_card(result: QueryResult, card_no_match_text: str) -> Activity:
        """
        Get active learning suggestions card.
        """

        if not result:
            raise TypeError("result is required")

        if not card_no_match_text:
            raise TypeError("card_no_match_text is required")

        # Add all prompts
        button_list = [
            CardAction(
                value=prompt.display_text, type="imBack", title=prompt.display_text,
            )
            for prompt in result.context.prompts
        ]

        # Add No match text
        #button_list.append(
        #    CardAction(
        #        value=card_no_match_text, type="imBack", title=card_no_match_text,
        #    )
        #)

        attachment = CardFactory.hero_card(HeroCard(buttons=button_list))

        return Activity(
            type=ActivityTypes.message, text=result.answer, attachments=[attachment]
        )

[sgellock]

We should knock this out early in R13 as it's been open for a while.

[Zerryth]

Hey @asdkant-ey! Just wanted to let you know, that I've started looking into this, and repro'd the issue.

At first I was perplexed about how to repro the issue, since I started debugging in C# instead of python, and I was getting expected behavior:

C#

vs.

Python

I'll close out dotnet issue for this for now, and also later verify if things are ok in JS. This may be solely isolated to the python SDK.

Fix should come shortly as well, as the issue seems pretty straight forward