Skip to content

Commit 06e0c5a

Browse files
wraverywravery
committed
Move static method definitions out of headers
1 parent 894360c commit 06e0c5a

File tree

13 files changed

+302
-223
lines changed

13 files changed

+302
-223
lines changed

‎samples/client/benchmark/BenchmarkClient.cpp‎

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -201,5 +201,25 @@ Response parseResponse(response::Value&& response)
201201
return result;
202202
}
203203

204+
[[nodiscard]] const std::string& Traits::GetRequestText() noexcept
205+
{
206+
return benchmark::GetRequestText();
207+
}
208+
209+
[[nodiscard]] const peg::ast& Traits::GetRequestObject() noexcept
210+
{
211+
return benchmark::GetRequestObject();
212+
}
213+
214+
[[nodiscard]] const std::string& Traits::GetOperationName() noexcept
215+
{
216+
return Query::GetOperationName();
217+
}
218+
219+
[[nodiscard]] Traits::Response Traits::parseResponse(response::Value&& response)
220+
{
221+
return Query::parseResponse(std::move(response));
222+
}
223+
204224
} // namespace query::Query
205225
} // namespace graphql::client

‎samples/client/benchmark/BenchmarkClient.h‎

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -98,27 +98,13 @@ struct [[nodiscard]] Response
9898

9999
struct Traits
100100
{
101-
[[nodiscard]] static const std::string& GetRequestText() noexcept
102-
{
103-
return benchmark::GetRequestText();
104-
}
105-
106-
[[nodiscard]] static const peg::ast& GetRequestObject() noexcept
107-
{
108-
return benchmark::GetRequestObject();
109-
}
110-
111-
[[nodiscard]] static const std::string& GetOperationName() noexcept
112-
{
113-
return Query::GetOperationName();
114-
}
101+
[[nodiscard]] static const std::string& GetRequestText() noexcept;
102+
[[nodiscard]] static const peg::ast& GetRequestObject() noexcept;
103+
[[nodiscard]] static const std::string& GetOperationName() noexcept;
115104

116105
using Response = Query::Response;
117106

118-
[[nodiscard]] static Response parseResponse(response::Value&& response)
119-
{
120-
return Query::parseResponse(std::move(response));
121-
}
107+
[[nodiscard]] static Response parseResponse(response::Value&& response);
122108
};
123109

124110
} // namespace query::Query

‎samples/client/multiple/MultipleQueriesClient.cpp‎

Lines changed: 105 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -288,6 +288,26 @@ Response parseResponse(response::Value&& response)
288288
return result;
289289
}
290290

291+
[[nodiscard]] const std::string& Traits::GetRequestText() noexcept
292+
{
293+
return multiple::GetRequestText();
294+
}
295+
296+
[[nodiscard]] const peg::ast& Traits::GetRequestObject() noexcept
297+
{
298+
return multiple::GetRequestObject();
299+
}
300+
301+
[[nodiscard]] const std::string& Traits::GetOperationName() noexcept
302+
{
303+
return Appointments::GetOperationName();
304+
}
305+
306+
[[nodiscard]] Traits::Response Traits::parseResponse(response::Value&& response)
307+
{
308+
return Appointments::parseResponse(std::move(response));
309+
}
310+
291311
} // namespace query::Appointments
292312

293313
template <>
@@ -401,6 +421,26 @@ Response parseResponse(response::Value&& response)
401421
return result;
402422
}
403423

424+
[[nodiscard]] const std::string& Traits::GetRequestText() noexcept
425+
{
426+
return multiple::GetRequestText();
427+
}
428+
429+
[[nodiscard]] const peg::ast& Traits::GetRequestObject() noexcept
430+
{
431+
return multiple::GetRequestObject();
432+
}
433+
434+
[[nodiscard]] const std::string& Traits::GetOperationName() noexcept
435+
{
436+
return Tasks::GetOperationName();
437+
}
438+
439+
[[nodiscard]] Traits::Response Traits::parseResponse(response::Value&& response)
440+
{
441+
return Tasks::parseResponse(std::move(response));
442+
}
443+
404444
} // namespace query::Tasks
405445

406446
template <>
@@ -514,6 +554,26 @@ Response parseResponse(response::Value&& response)
514554
return result;
515555
}
516556

557+
[[nodiscard]] const std::string& Traits::GetRequestText() noexcept
558+
{
559+
return multiple::GetRequestText();
560+
}
561+
562+
[[nodiscard]] const peg::ast& Traits::GetRequestObject() noexcept
563+
{
564+
return multiple::GetRequestObject();
565+
}
566+
567+
[[nodiscard]] const std::string& Traits::GetOperationName() noexcept
568+
{
569+
return UnreadCounts::GetOperationName();
570+
}
571+
572+
[[nodiscard]] Traits::Response Traits::parseResponse(response::Value&& response)
573+
{
574+
return UnreadCounts::parseResponse(std::move(response));
575+
}
576+
517577
} // namespace query::UnreadCounts
518578

519579
template <>
@@ -635,6 +695,26 @@ Response parseResponse(response::Value&& response)
635695
return result;
636696
}
637697

698+
[[nodiscard]] const std::string& Traits::GetRequestText() noexcept
699+
{
700+
return multiple::GetRequestText();
701+
}
702+
703+
[[nodiscard]] const peg::ast& Traits::GetRequestObject() noexcept
704+
{
705+
return multiple::GetRequestObject();
706+
}
707+
708+
[[nodiscard]] const std::string& Traits::GetOperationName() noexcept
709+
{
710+
return Miscellaneous::GetOperationName();
711+
}
712+
713+
[[nodiscard]] Traits::Response Traits::parseResponse(response::Value&& response)
714+
{
715+
return Miscellaneous::parseResponse(std::move(response));
716+
}
717+
638718
} // namespace query::Miscellaneous
639719

640720
template <>
@@ -766,5 +846,30 @@ Response parseResponse(response::Value&& response)
766846
return result;
767847
}
768848

849+
[[nodiscard]] const std::string& Traits::GetRequestText() noexcept
850+
{
851+
return multiple::GetRequestText();
852+
}
853+
854+
[[nodiscard]] const peg::ast& Traits::GetRequestObject() noexcept
855+
{
856+
return multiple::GetRequestObject();
857+
}
858+
859+
[[nodiscard]] const std::string& Traits::GetOperationName() noexcept
860+
{
861+
return CompleteTaskMutation::GetOperationName();
862+
}
863+
864+
[[nodiscard]] response::Value Traits::serializeVariables(Traits::Variables&& variables)
865+
{
866+
return CompleteTaskMutation::serializeVariables(std::move(variables));
867+
}
868+
869+
[[nodiscard]] Traits::Response Traits::parseResponse(response::Value&& response)
870+
{
871+
return CompleteTaskMutation::parseResponse(std::move(response));
872+
}
873+
769874
} // namespace mutation::CompleteTaskMutation
770875
} // namespace graphql::client

‎samples/client/multiple/MultipleQueriesClient.h‎

Lines changed: 21 additions & 94 deletions
Original file line numberDiff line numberDiff line change
@@ -182,27 +182,13 @@ struct [[nodiscard]] Response
182182

183183
struct Traits
184184
{
185-
[[nodiscard]] static const std::string& GetRequestText() noexcept
186-
{
187-
return multiple::GetRequestText();
188-
}
189-
190-
[[nodiscard]] static const peg::ast& GetRequestObject() noexcept
191-
{
192-
return multiple::GetRequestObject();
193-
}
194-
195-
[[nodiscard]] static const std::string& GetOperationName() noexcept
196-
{
197-
return Appointments::GetOperationName();
198-
}
185+
[[nodiscard]] static const std::string& GetRequestText() noexcept;
186+
[[nodiscard]] static const peg::ast& GetRequestObject() noexcept;
187+
[[nodiscard]] static const std::string& GetOperationName() noexcept;
199188

200189
using Response = Appointments::Response;
201190

202-
[[nodiscard]] static Response parseResponse(response::Value&& response)
203-
{
204-
return Appointments::parseResponse(std::move(response));
205-
}
191+
[[nodiscard]] static Response parseResponse(response::Value&& response);
206192
};
207193

208194
} // namespace query::Appointments
@@ -242,27 +228,13 @@ struct [[nodiscard]] Response
242228

243229
struct Traits
244230
{
245-
[[nodiscard]] static const std::string& GetRequestText() noexcept
246-
{
247-
return multiple::GetRequestText();
248-
}
249-
250-
[[nodiscard]] static const peg::ast& GetRequestObject() noexcept
251-
{
252-
return multiple::GetRequestObject();
253-
}
254-
255-
[[nodiscard]] static const std::string& GetOperationName() noexcept
256-
{
257-
return Tasks::GetOperationName();
258-
}
231+
[[nodiscard]] static const std::string& GetRequestText() noexcept;
232+
[[nodiscard]] static const peg::ast& GetRequestObject() noexcept;
233+
[[nodiscard]] static const std::string& GetOperationName() noexcept;
259234

260235
using Response = Tasks::Response;
261236

262-
[[nodiscard]] static Response parseResponse(response::Value&& response)
263-
{
264-
return Tasks::parseResponse(std::move(response));
265-
}
237+
[[nodiscard]] static Response parseResponse(response::Value&& response);
266238
};
267239

268240
} // namespace query::Tasks
@@ -302,27 +274,13 @@ struct [[nodiscard]] Response
302274

303275
struct Traits
304276
{
305-
[[nodiscard]] static const std::string& GetRequestText() noexcept
306-
{
307-
return multiple::GetRequestText();
308-
}
309-
310-
[[nodiscard]] static const peg::ast& GetRequestObject() noexcept
311-
{
312-
return multiple::GetRequestObject();
313-
}
314-
315-
[[nodiscard]] static const std::string& GetOperationName() noexcept
316-
{
317-
return UnreadCounts::GetOperationName();
318-
}
277+
[[nodiscard]] static const std::string& GetRequestText() noexcept;
278+
[[nodiscard]] static const peg::ast& GetRequestObject() noexcept;
279+
[[nodiscard]] static const std::string& GetOperationName() noexcept;
319280

320281
using Response = UnreadCounts::Response;
321282

322-
[[nodiscard]] static Response parseResponse(response::Value&& response)
323-
{
324-
return UnreadCounts::parseResponse(std::move(response));
325-
}
283+
[[nodiscard]] static Response parseResponse(response::Value&& response);
326284
};
327285

328286
} // namespace query::UnreadCounts
@@ -359,27 +317,13 @@ struct [[nodiscard]] Response
359317

360318
struct Traits
361319
{
362-
[[nodiscard]] static const std::string& GetRequestText() noexcept
363-
{
364-
return multiple::GetRequestText();
365-
}
366-
367-
[[nodiscard]] static const peg::ast& GetRequestObject() noexcept
368-
{
369-
return multiple::GetRequestObject();
370-
}
371-
372-
[[nodiscard]] static const std::string& GetOperationName() noexcept
373-
{
374-
return Miscellaneous::GetOperationName();
375-
}
320+
[[nodiscard]] static const std::string& GetRequestText() noexcept;
321+
[[nodiscard]] static const peg::ast& GetRequestObject() noexcept;
322+
[[nodiscard]] static const std::string& GetOperationName() noexcept;
376323

377324
using Response = Miscellaneous::Response;
378325

379-
[[nodiscard]] static Response parseResponse(response::Value&& response)
380-
{
381-
return Miscellaneous::parseResponse(std::move(response));
382-
}
326+
[[nodiscard]] static Response parseResponse(response::Value&& response);
383327
};
384328

385329
} // namespace query::Miscellaneous
@@ -426,34 +370,17 @@ struct [[nodiscard]] Response
426370

427371
struct Traits
428372
{
429-
[[nodiscard]] static const std::string& GetRequestText() noexcept
430-
{
431-
return multiple::GetRequestText();
432-
}
433-
434-
[[nodiscard]] static const peg::ast& GetRequestObject() noexcept
435-
{
436-
return multiple::GetRequestObject();
437-
}
438-
439-
[[nodiscard]] static const std::string& GetOperationName() noexcept
440-
{
441-
return CompleteTaskMutation::GetOperationName();
442-
}
373+
[[nodiscard]] static const std::string& GetRequestText() noexcept;
374+
[[nodiscard]] static const peg::ast& GetRequestObject() noexcept;
375+
[[nodiscard]] static const std::string& GetOperationName() noexcept;
443376

444377
using Variables = CompleteTaskMutation::Variables;
445378

446-
[[nodiscard]] static response::Value serializeVariables(Variables&& variables)
447-
{
448-
return CompleteTaskMutation::serializeVariables(std::move(variables));
449-
}
379+
[[nodiscard]] static response::Value serializeVariables(Variables&& variables);
450380

451381
using Response = CompleteTaskMutation::Response;
452382

453-
[[nodiscard]] static Response parseResponse(response::Value&& response)
454-
{
455-
return CompleteTaskMutation::parseResponse(std::move(response));
456-
}
383+
[[nodiscard]] static Response parseResponse(response::Value&& response);
457384
};
458385

459386
} // namespace mutation::CompleteTaskMutation

‎samples/client/mutate/MutateClient.cpp‎

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -261,5 +261,30 @@ Response parseResponse(response::Value&& response)
261261
return result;
262262
}
263263

264+
[[nodiscard]] const std::string& Traits::GetRequestText() noexcept
265+
{
266+
return mutate::GetRequestText();
267+
}
268+
269+
[[nodiscard]] const peg::ast& Traits::GetRequestObject() noexcept
270+
{
271+
return mutate::GetRequestObject();
272+
}
273+
274+
[[nodiscard]] const std::string& Traits::GetOperationName() noexcept
275+
{
276+
return CompleteTaskMutation::GetOperationName();
277+
}
278+
279+
[[nodiscard]] response::Value Traits::serializeVariables(Traits::Variables&& variables)
280+
{
281+
return CompleteTaskMutation::serializeVariables(std::move(variables));
282+
}
283+
284+
[[nodiscard]] Traits::Response Traits::parseResponse(response::Value&& response)
285+
{
286+
return CompleteTaskMutation::parseResponse(std::move(response));
287+
}
288+
264289
} // namespace mutation::CompleteTaskMutation
265290
} // namespace graphql::client

0 commit comments

Comments
 (0)