Merge pull request #286 from wravery/sonar-qube

Fixing SonarQube static analysis warnings

Author: wravery

include/SchemaLoader.h

@@ -20,7 +20,8 @@
 namespace graphql::generator {
 
 // These are the set of built-in types in GraphQL.
-enum class [[nodiscard]] BuiltinType {
+enum class [[nodiscard]] BuiltinType
+{
 	Int,
 	Float,
 	String,
@@ -75,7 +76,8 @@ using EnumTypeList = std::vector<EnumType>;
 // Input types are complex types that have a set of named fields. Each field may be
 // a scalar type (including lists or non-null wrappers) or another nested input type,
 // but it cannot include output object types.
-enum class [[nodiscard]] InputFieldType {
+enum class [[nodiscard]] InputFieldType
+{
 	Builtin,
 	Scalar,
 	Enum,
@@ -136,7 +138,8 @@ using UnionTypeList = std::vector<UnionType>;
 // field may be a scalar type (including lists or non-null wrappers) or another nested
 // output type, but it cannot include input object types. Each field can also take
 // optional arguments which are all input types.
-enum class [[nodiscard]] OutputFieldType {
+enum class [[nodiscard]] OutputFieldType
+{
 	Builtin,
 	Scalar,
 	Enum,
@@ -264,6 +267,8 @@ class [[nodiscard]] SchemaLoader
 	[[nodiscard]] static std::string getOutputCppAccessor(const OutputField& field) noexcept;
 	[[nodiscard]] static std::string getOutputCppResolver(const OutputField& field) noexcept;
 
+	[[nodiscard]] static bool shouldMoveInputField(const InputField& field) noexcept;
+
 private:
 	[[nodiscard]] static bool isExtension(const peg::ast_node& definition) noexcept;
 

include/graphqlservice/GraphQLResponse.h

@@ -33,7 +33,8 @@ namespace graphql::response {
 // GraphQL responses are not technically JSON-specific, although that is probably the most common
 // way of representing them. These are the primitive types that may be represented in GraphQL, as
 // of the [October 2021 spec](https://spec.graphql.org/October2021/#sec-Serialization-Format).
-enum class [[nodiscard]] Type : std::uint8_t {
+enum class [[nodiscard]] Type : std::uint8_t
+{
 	Map,	   // JSON Object
 	List,	   // JSON Array
 	String,	   // JSON String
@@ -392,7 +393,7 @@ class [[nodiscard]] Writer final
 	template <class T>
 	struct Model : Concept
 	{
-		Model(std::unique_ptr<T>&& pimpl)
+		explicit Model(std::unique_ptr<T> pimpl) noexcept
 			: _pimpl { std::move(pimpl) }
 		{
 		}
@@ -455,7 +456,7 @@ class [[nodiscard]] Writer final
 
 public:
 	template <class T>
-	Writer(std::unique_ptr<T> writer)
+	Writer(std::unique_ptr<T> writer) noexcept
 		: _concept { std::static_pointer_cast<const Concept>(
 			std::make_shared<Model<T>>(std::move(writer))) }
 	{