Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ebpf_hash_table_create should use ebpf_epoch_allocate_with_tag instead of ebpf_epoch_allocate to better identify pool allocations. #4125

Open
shankarseal opened this issue Jan 10, 2025 · 0 comments
Assignees
Labels
diagnostics P3 triaged Discussed in a triage meeting
Milestone

Comments

@shankarseal
Copy link
Collaborator

Currently ebpf_hash_table_create uses ebpf_epoch_allocate as the default allocation method which uses the EBPF_POOL_TAG_EPOCH pool tag. This makes it difficult to distinguish between the objects (maps, pinning table etc.) that are implemented using the hashtable when performing memory usage analysis. If should use ebpf_epoch_allocate_with_tag instead and let the caller pass the tag that would help us identify the underlying object.

@shankarseal shankarseal self-assigned this Jan 13, 2025
@shankarseal shankarseal added triaged Discussed in a triage meeting P3 labels Jan 13, 2025
@shankarseal shankarseal added this to the 2502 milestone Jan 13, 2025
@shankarseal shankarseal modified the milestones: 2502, 2504, 2503, Backlog, 2501 Jan 22, 2025
@shankarseal shankarseal modified the milestones: 2503, 2504, 2505 Jan 31, 2025
@shankarseal shankarseal assigned nigriMSFT and unassigned shankarseal Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diagnostics P3 triaged Discussed in a triage meeting
Projects
None yet
Development

No branches or pull requests

2 participants