Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement implicit_context for helper functions. #3656

Merged
merged 46 commits into from
Jul 19, 2024
Merged

Implement implicit_context for helper functions. #3656

merged 46 commits into from
Jul 19, 2024

Conversation

saxena-anurag
Copy link
Contributor

@saxena-anurag saxena-anurag commented Jun 20, 2024 •
edited
Loading

Fixes #3645

Description

This PR contains changes to support implicit context for helper functions. This required the following changes:

  1. Update native code generation to also pass ctx to all the helper functions as 6th argument. Note that ubpf already does the same for JIT and interpret paths (though there was a bug in ubpf which was recently fixed, and is now included in eBPF).
  2. Changed logic to resolve helper functions to now also get whether the helper function requires implicit context.
  3. Checks in native module to ensure that an older native module (that does not support implicit context) does not get loaded if the extension requires implicit context for any of the helper functions used by the native module.
  4. Updated the minor version to 0.18.0, to allow adding checks in native code.

Testing

Existing CICD. Also added new tests for implicit context.

Documentation

Updated documentation.

Installation

No.

mtfriesen
mtfriesen previously approved these changes Jul 15, 2024
View reviewed changes
Alan-Jowett
Alan-Jowett previously approved these changes Jul 17, 2024
View reviewed changes
@saxena-anurag saxena-anurag added this pull request to the merge queue Jul 19, 2024
Merged via the queue into microsoft:main with commit ffb3638 Jul 19, 2024
88 checks passed
@saxena-anurag saxena-anurag mentioned this pull request Jul 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alan-Jowett Alan-Jowett Alan-Jowett approved these changes

@matthewige matthewige matthewige approved these changes

@dthaler dthaler Awaiting requested review from dthaler dthaler is a code owner

@poornagmsft poornagmsft Awaiting requested review from poornagmsft poornagmsft is a code owner

@shankarseal shankarseal Awaiting requested review from shankarseal shankarseal is a code owner

@dv-msft dv-msft Awaiting requested review from dv-msft dv-msft is a code owner

@gtrevi gtrevi Awaiting requested review from gtrevi gtrevi is a code owner

@shpalani shpalani Awaiting requested review from shpalani shpalani is a code owner

@rectified95 rectified95 Awaiting requested review from rectified95 rectified95 is a code owner

@mtfriesen mtfriesen Awaiting requested review from mtfriesen mtfriesen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for implicit context for helper functions
4 participants
@saxena-anurag @mtfriesen @matthewige @Alan-Jowett