feature: support azure MangedIdentity TokenCredential #590
Conversation
libs/storage/Tsavorite/cs/src/devices/AzureStorageDevice/AzureStorageNamedDeviceFactory.cs
Show resolved
Hide resolved
|
How does this feature work exactly? Is it compatible with the older connection strings? And how does it interface with unit tests? |
Assuming the garnet application will run inside of azure (ex: vm / aks) and managed identity will be able to be assigned to the environment
I think this us instead of using a connection string, so any Metadata provided in the connection string will need to be provided in a different way
We might consider using Currently the unit tests don't use the managed identity credential to perform the login |
| { | ||
| Assert.Ignore("Azure tests are disabled."); | ||
| } | ||
|
|
||
| var AzureTestDirectory = $"{TestContext.CurrentContext.Test.MethodName.ToLowerInvariant()}"; | ||
| var configPath = $"{AzureTestDirectory}/test1.config"; | ||
| var AzureEmulatedStorageString = "UseDevelopmentStorage=true;"; |
There was a problem hiding this comment.
Add a unit test that uses the new version of identity.
There was a problem hiding this comment.
Any progress on this? We would need it to be confident that the feature works (now, and in future as the codebase evolves).
There was a problem hiding this comment.
I'm hoping to get to this by the end of this week
There was a problem hiding this comment.
Any update on this? Feel free to close and re-open when you have made progress on it, thanks.
There was a problem hiding this comment.
@badrishc I'm not sure how to test this locally, I got garnet to run but I'm not sure how to force garnet to save into the blob storage
There was a problem hiding this comment.
OK, I got garnet to interact with the azure blob storage I created.
|
Somthing that might be concerning, I noticed that the constructor of running locally with called the constructor 5 times, this causes the time until the service prints created #739 |
closes #558
Tests: