Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Garnet Monitoring Integration in Helm Chart #629

Open
vitalygorohovik93 opened this issue Sep 3, 2024 · 3 comments
Open

Garnet Monitoring Integration in Helm Chart #629

vitalygorohovik93 opened this issue Sep 3, 2024 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@vitalygorohovik93
Copy link

Feature request type

sample request

Is your feature request related to a problem? Please describe

Integrate monitoring capabilities for Garnet within the existing Helm chart to enhance observability and ensure efficient tracking of system performance.

Describe the solution you'd like

  1. Prometheus Setup:
    Add Prometheus as an optional dependency in the Helm chart.
    Configure Prometheus to scrape metrics from Garnet endpoints.

  2. Grafana Dashboards:
    Provide pre-configured Grafana dashboards for visualizing key metrics.
    Allow customization of dashboards for user-specific needs.
    3.Alerting:
    Set up default alerting rules in Prometheus.
    Enable integration with notification systems like Slack or email.
    4.Helm Values Configuration:
    Allow users to enable/disable monitoring through Helm values.
    Provide configuration options for custom metrics and alert thresholds.
    5.Documentation:
    Update Helm chart documentation with setup instructions.
    Include examples for custom configurations and troubleshooting tips.

Describe alternatives you've considered

No response

Additional context

Integrating monitoring into the Garnet Helm chart will significantly benefit system administrators by providing real-time insights and alerts, ultimately enhancing system reliability and performance.

@TalZaccai TalZaccai added the help wanted Extra attention is needed label Sep 3, 2024
@Meir017
Copy link
Contributor

Meir017 commented Sep 3, 2024

@vitalygorohovik93 would this be based on the redis RESP protocol that garnet exposes or something specific to garnet? meaning - is there some existing docker image we could simply add as a another container or do we need to create something new?

@PaulusParssinen
Copy link
Contributor

Grafana/Prometheus integration probably requires #379

@Vijay-Nirmal
Copy link
Contributor

We can use Grafana OSS with the Redis plugin, which comes with a built-in dashboard. The problem is that some panels don't show data, as comments (like COMMANDSTATS, SLOWLOG) are not yet supported. Other panels worked as expected when I tested them locally with Garnet. @PaulusParssinen, we don't need OpenTelemetry; this works with the RESP protocol. Still better to have OpenTelemetry as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants