Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize azure blob storage client once during startup #739

Open
Meir017 opened this issue Oct 20, 2024 · 0 comments · May be fixed by #740
Open

Initialize azure blob storage client once during startup #739

Meir017 opened this issue Oct 20, 2024 · 0 comments · May be fixed by #740

Comments

@Meir017
Copy link
Contributor

Meir017 commented Oct 20, 2024

Describe the bug

In Garnet.Options we use a Func<INamedDeviceFactory> that each time called returns a new instance.

We could use a Lazy<INamedDeviceFactory> here to reduce the instances used to 1.

Steps to reproduce the bug

  1. added log message in AzureStorageNamedDeviceFactory contructor,
    ex:
logger?.LogInformation("AzureStorageNamedDeviceFactory: serviceUri: {serviceUri}", serviceUri);
  1. Start the server and see this message multiple times

Expected behavior

AzureStorageNamedDeviceFactory should be created only once

Screenshots

No response

Release version

No response

IDE

No response

OS version

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant