refactor: replace rollup with tsc for browser package builds

layershifter · claude · layershifter · commit 5da2a63b899e · 2026-03-06T14:23:07.000+01:00
Replace rollup with dual tsc configs (ESM + CJS) for core, react,
shadow-dom, and style-types. Each package now has a tsconfig.lib.cjs.json
that emits CJS to dist/cjs/ using module: "node16".

- Delete rollup.config.cjs from 4 browser packages
- Add tsconfig.lib.cjs.json for CJS output
- Add explicit build targets in project.json (ESM + CJS)
- Update exports to ./dist/index.js and ./dist/cjs/index.js
- Remove @nx/rollup/plugin from nx.json

Co-Authored-By: Claude Opus 4.6 &lt;noreply@anthropic.com&gt;
diff --git a/nx.json b/nx.json
@@ -54,12 +54,6 @@
           "configName": "tsconfig.lib.json"
         }
       }
-    },
-    {
-      "plugin": "@nx/rollup/plugin",
-      "options": {
-        "buildTargetName": "build"
-      }
     }
   ],
   "pluginsConfig": {
diff --git a/packages/core/package.json b/packages/core/package.json
@@ -17,9 +17,9 @@
     ".": {
       "@griffel/source": "./src/index.ts",
       "types": "./dist/index.d.ts",
-      "import": "./dist/index.esm.js",
-      "require": "./dist/index.cjs.js",
-      "default": "./dist/index.esm.js"
+      "import": "./dist/index.js",
+      "require": "./dist/cjs/index.js",
+      "default": "./dist/index.js"
     }
   },
   "dependencies": {
diff --git a/packages/core/project.json b/packages/core/project.json
@@ -5,6 +5,16 @@
   "projectType": "library",
   "tags": [],
   "targets": {
+    "build": {
+      "dependsOn": ["^build"],
+      "executor": "nx:run-commands",
+      "outputs": ["{projectRoot}/dist"],
+      "options": {
+        "cwd": "{projectRoot}",
+        "commands": ["tsc -b tsconfig.lib.json --pretty", "tsc -p tsconfig.lib.cjs.json --pretty"],
+        "parallel": false
+      }
+    },
     "lint": {
       "executor": "@nx/eslint:lint",
       "outputs": ["{options.outputFile}"]
diff --git a/packages/core/rollup.config.cjs b/packages/core/rollup.config.cjs
diff --git a/packages/core/tsconfig.lib.cjs.json b/packages/core/tsconfig.lib.cjs.json
@@ -0,0 +1,14 @@
+{
+  "extends": "./tsconfig.lib.json",
+  "compilerOptions": {
+    "module": "node16",
+    "moduleResolution": "node16",
+    "outDir": "./dist/cjs",
+    "composite": false,
+    "declaration": false,
+    "declarationMap": false,
+    "sourceMap": false,
+    "incremental": false
+  },
+  "references": []
+}
diff --git a/packages/react/package.json b/packages/react/package.json
@@ -17,9 +17,9 @@
     ".": {
       "@griffel/source": "./src/index.ts",
       "types": "./dist/index.d.ts",
-      "import": "./dist/index.esm.js",
-      "require": "./dist/index.cjs.js",
-      "default": "./dist/index.esm.js"
+      "import": "./dist/index.js",
+      "require": "./dist/cjs/index.js",
+      "default": "./dist/index.js"
     }
   },
   "wyw-in-js": {
diff --git a/packages/react/project.json b/packages/react/project.json
@@ -5,6 +5,16 @@
   "projectType": "library",
   "tags": [],
   "targets": {
+    "build": {
+      "dependsOn": ["^build"],
+      "executor": "nx:run-commands",
+      "outputs": ["{projectRoot}/dist"],
+      "options": {
+        "cwd": "{projectRoot}",
+        "commands": ["tsc -b tsconfig.lib.json --pretty", "tsc -p tsconfig.lib.cjs.json --pretty"],
+        "parallel": false
+      }
+    },
     "lint": {
       "executor": "@nx/eslint:lint",
       "outputs": ["{options.outputFile}"]
diff --git a/packages/react/rollup.config.cjs b/packages/react/rollup.config.cjs
diff --git a/packages/react/tsconfig.lib.cjs.json b/packages/react/tsconfig.lib.cjs.json
@@ -0,0 +1,14 @@
+{
+  "extends": "./tsconfig.lib.json",
+  "compilerOptions": {
+    "module": "node16",
+    "moduleResolution": "node16",
+    "outDir": "./dist/cjs",
+    "composite": false,
+    "declaration": false,
+    "declarationMap": false,
+    "sourceMap": false,
+    "incremental": false
+  },
+  "references": []
+}
diff --git a/packages/shadow-dom/package.json b/packages/shadow-dom/package.json
@@ -17,9 +17,9 @@
     ".": {
       "@griffel/source": "./src/index.ts",
       "types": "./dist/index.d.ts",
-      "import": "./dist/index.esm.js",
-      "require": "./dist/index.cjs.js",
-      "default": "./dist/index.esm.js"
+      "import": "./dist/index.js",
+      "require": "./dist/cjs/index.js",
+      "default": "./dist/index.js"
     }
   },
   "devDependencies": {
diff --git a/packages/shadow-dom/project.json b/packages/shadow-dom/project.json
@@ -5,6 +5,16 @@
   "projectType": "library",
   "tags": [],
   "targets": {
+    "build": {
+      "dependsOn": ["^build"],
+      "executor": "nx:run-commands",
+      "outputs": ["{projectRoot}/dist"],
+      "options": {
+        "cwd": "{projectRoot}",
+        "commands": ["tsc -b tsconfig.lib.json --pretty", "tsc -p tsconfig.lib.cjs.json --pretty"],
+        "parallel": false
+      }
+    },
     "lint": {
       "executor": "@nx/eslint:lint",
       "outputs": ["{options.outputFile}"]
diff --git a/packages/shadow-dom/rollup.config.cjs b/packages/shadow-dom/rollup.config.cjs
diff --git a/packages/shadow-dom/tsconfig.lib.cjs.json b/packages/shadow-dom/tsconfig.lib.cjs.json
@@ -0,0 +1,14 @@
+{
+  "extends": "./tsconfig.lib.json",
+  "compilerOptions": {
+    "module": "node16",
+    "moduleResolution": "node16",
+    "outDir": "./dist/cjs",
+    "composite": false,
+    "declaration": false,
+    "declarationMap": false,
+    "sourceMap": false,
+    "incremental": false
+  },
+  "references": []
+}
diff --git a/packages/style-types/package.json b/packages/style-types/package.json
@@ -19,9 +19,9 @@
     ".": {
       "@griffel/source": "./src/index.ts",
       "types": "./dist/index.d.ts",
-      "import": "./dist/index.esm.js",
-      "require": "./dist/index.cjs.js",
-      "default": "./dist/index.esm.js"
+      "import": "./dist/index.js",
+      "require": "./dist/cjs/index.js",
+      "default": "./dist/index.js"
     }
   },
   "types": "./dist/index.d.ts",
diff --git a/packages/style-types/project.json b/packages/style-types/project.json
@@ -4,6 +4,16 @@
   "sourceRoot": "packages/style-types/src",
   "tags": [],
   "targets": {
+    "build": {
+      "dependsOn": ["^build"],
+      "executor": "nx:run-commands",
+      "outputs": ["{projectRoot}/dist"],
+      "options": {
+        "cwd": "{projectRoot}",
+        "commands": ["tsc -b tsconfig.lib.json --pretty", "tsc -p tsconfig.lib.cjs.json --pretty"],
+        "parallel": false
+      }
+    },
     "lint": {
       "executor": "@nx/eslint:lint",
       "outputs": ["{options.outputFile}"]
diff --git a/packages/style-types/rollup.config.cjs b/packages/style-types/rollup.config.cjs
diff --git a/packages/style-types/tsconfig.lib.cjs.json b/packages/style-types/tsconfig.lib.cjs.json
@@ -0,0 +1,14 @@
+{
+  "extends": "./tsconfig.lib.json",
+  "compilerOptions": {
+    "module": "node16",
+    "moduleResolution": "node16",
+    "outDir": "./dist/cjs",
+    "composite": false,
+    "declaration": false,
+    "declarationMap": false,
+    "sourceMap": false,
+    "incremental": false
+  },
+  "references": []
+}

Original file line number	Diff line number	Diff line change
`@@ -54,12 +54,6 @@`
`54`	`54`	`"configName": "tsconfig.lib.json"`
`55`	`55`	`}`
`56`	`56`	`}`
`57`		`- },`
`58`		`- {`
`59`		`- "plugin": "@nx/rollup/plugin",`
`60`		`- "options": {`
`61`		`- "buildTargetName": "build"`
`62`		`- }`
`63`	`57`	`}`
`64`	`58`	`],`
`65`	`59`	`"pluginsConfig": {`