React 19 support

[zoontek]

Hi 👋

I was wondering if there's anything that prevents React 19 usage?
Griffel is the latest piece of my stack that prevent me from updating (see "react": ">=16.8.0 <19.0.0")

[layershifter]

Hey, actually nothing. I made a change in #668 and it's already on NPM 🚢

[zoontek]

Thank you! 🙏

[ProxySoul]

@layershifter there is an issue here with react 19, works fine with Vite but not with rspack
packages/react/src/utils/isInsideComponent.ts "secret internals" are not available in react 19 anymore

[ProxySoul]

error Build error: File: ./node_modules/.pnpm/@griffel+react@1.5.30_react@19.2.0/node_modules/@griffel/react/utils/isInsideComponent.esm.js:1:1 × ESModulesLinkingError: export '__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED' (imported as 'React') was not found in 'react' (possible exports: Activity, Children, Component, Fragment, Profiler , PureComponent, StrictMode, Suspense, __CLIENT_INTERNALS_DO_NOT_USE_OR_WARN_USERS_THEY_CANNOT_UPGRADE, __COMPILER_RUNTIME, cache, cacheSignal, cloneElement, createContext, createElement, createRef, for wardRef, isValidElement, lazy, memo, startTransition, unstable_useCacheRefresh, use, useActionState, useCallback, useContext, useDebugValue, useDeferredValue, useEffect, useEffectEvent, useId, useImpera tiveHandle, useInsertionEffect, useLayoutEffect, useMemo, useOptimistic, useReducer, useRef, useState, useSyncExternalStore, useTransition, version) ╭─[8:23] 6 │ try { 7 │ // @ts-expect-error "SECRET_INTERNALS" are not typed 8 │ const dispatcher = React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED.ReactCurrentDispatcher.current; · ─────────────────────────────────────────────────────────────────────────────────────── 9 │ // Before any React component was rendered "dispatcher" will be "null" 10 │ if (dispatcher === null || dispatcher === undefined) { ╰────

[layershifter]

@Pouiiro interesting. Do you mind to create a simple repro repository that could be cloned? Or Stackblitz?

[ProxySoul]

here you go Stackblitz
@layershifter

[ProxySoul]

the issue happens when you build

[layershifter]

@Pouiiro thx 👍 I forgot about this smart check, the fix should be quite simple, https://github.com/microsoft/use-disposable/blob/da61bd108a1451233616cdfdf16e4f304cc6d6ef/src/useIsStrictMode.ts#L8-L23. Will try to apply it today.

[layershifter]

Opened a PR, #723. Will release once merged