You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #2779 (commit 2be7fc3) removed the die() helper from .github/skills/project-planning/gitlab/scripts/gitlab.py, making GitLabError the module's single failure mechanism. Two documentation artifacts still describe the old die()-based behavior and were not updated in that commit:
docs/security/security-model.md:
GL-1 threat description: "A raw exception, die() message, or diagnostic embedding the URL, headers, or upstream body could surface the token"
GL-4 title and content: "die() Helper Printing Raw Upstream Body" — "The die() helper prints an error string and exits..." and "local configuration failures use die(), which routes through _emit"
Lines ~2161-2169: title "die() helper printing raw upstream body" and description "die() prints an error string; a raw upstream body could leak secrets"
Expected Behavior
Both documents should describe the current single-mechanism contract: local configuration and validation failures raise GitLabError (not die()), which is caught once at the main() boundary and emitted via _emit(). The GL-4 threat entry and its yaml counterpart should be renamed/reworded to reflect GitLabError-based emission instead of die().
Compare against docs/security/security-model.md (GL-1, GL-4 sections) and docs/planning/threat-models/hve-core-comprehensive.yaml (~lines 2100-2170), which still reference die() as an active code path.
Bug Description
PR #2779 (commit 2be7fc3) removed the
die()helper from.github/skills/project-planning/gitlab/scripts/gitlab.py, makingGitLabErrorthe module's single failure mechanism. Two documentation artifacts still describe the olddie()-based behavior and were not updated in that commit:docs/security/security-model.md:die()message, or diagnostic embedding the URL, headers, or upstream body could surface the token"die()Helper Printing Raw Upstream Body" — "Thedie()helper prints an error string and exits..." and "local configuration failures usedie(), which routes through_emit"docs/planning/threat-models/hve-core-comprehensive.yaml:Expected Behavior
Both documents should describe the current single-mechanism contract: local configuration and validation failures raise
GitLabError(notdie()), which is caught once at themain()boundary and emitted via_emit(). The GL-4 threat entry and its yaml counterpart should be renamed/reworded to reflectGitLabError-based emission instead ofdie().Steps to Reproduce
die()fromgitlab.py.docs/security/security-model.md(GL-1, GL-4 sections) anddocs/planning/threat-models/hve-core-comprehensive.yaml(~lines 2100-2170), which still referencedie()as an active code path.Additional Context
.github/skills/project-planning/gitlab/scripts/gitlab.pydocs/security/security-model.md,docs/planning/threat-models/hve-core-comprehensive.yamlpath:linereferences in [security] Architectural: introduce central output sink + LOGGER + typed error class to jira/gitlab skills #1555 are stale... Worth correcting the issue body on close." — this issue is a related but distinct doc-drift item scoped to the security-model threat descriptions.