Skip to content

docs: Update security-model docs to remove stale die() references after GitLab die() removal #2829

Description

@github-actions

Bug Description

PR #2779 (commit 2be7fc3) removed the die() helper from .github/skills/project-planning/gitlab/scripts/gitlab.py, making GitLabError the module's single failure mechanism. Two documentation artifacts still describe the old die()-based behavior and were not updated in that commit:

  • docs/security/security-model.md:
    • GL-1 threat description: "A raw exception, die() message, or diagnostic embedding the URL, headers, or upstream body could surface the token"
    • GL-4 title and content: "die() Helper Printing Raw Upstream Body" — "The die() helper prints an error string and exits..." and "local configuration failures use die(), which routes through _emit"
  • docs/planning/threat-models/hve-core-comprehensive.yaml:
    • Lines ~2106, 2113: description mentioning "die() message"
    • Lines ~2161-2169: title "die() helper printing raw upstream body" and description "die() prints an error string; a raw upstream body could leak secrets"

Expected Behavior

Both documents should describe the current single-mechanism contract: local configuration and validation failures raise GitLabError (not die()), which is caught once at the main() boundary and emitted via _emit(). The GL-4 threat entry and its yaml counterpart should be renamed/reworded to reflect GitLabError-based emission instead of die().

Steps to Reproduce

  1. See commit 2be7fc3 (PR refactor(skills)!: remove the GitLab die() helper in favor of GitLabError #2779), which deletes die() from gitlab.py.
  2. Compare against docs/security/security-model.md (GL-1, GL-4 sections) and docs/planning/threat-models/hve-core-comprehensive.yaml (~lines 2100-2170), which still reference die() as an active code path.

Additional Context

Generated by Documentation Update Check · auto · 34.9 AIC · ⌖ 1.91 AIC · ⊞ 11.1K ·

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent-readydocumentationImprovements or additions to documentationneeds-triageRequires triage and prioritization

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions