Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce code complexity in flake file #1423

Open
dsrivastavv opened this issue Jul 17, 2021 · 1 comment
Open

Reduce code complexity in flake file #1423

dsrivastavv opened this issue Jul 17, 2021 · 1 comment
Labels
good first issue simple issue to help onboard to LISA

Comments

@dsrivastavv
Copy link
Contributor

Reduce code complexity to improve code quality. It's currently set to 15 in flake8 config file.

@dsrivastavv
Copy link
Contributor Author

If reduced to 10, the following errors need to be fixed :

.\lisa\runner.py:235:5: C901 'RootRunner._start_loop' is too complex (15)
.\lisa\search_space.py:97:5: C901 'IntRange.check' is too complex (12)
.\lisa\search_space.py:299:1: C901 'check_countspace' is too complex (13)
.\lisa\runners\legacy_runner.py:629:1: C901 '_track_progress' is too complex (13)
.\lisa\sut_orchestrator\azure\platform_.py:601:5: C901 'AzurePlatform._get_environment_information' is too complex (15)
.\lisa\sut_orchestrator\azure\platform_.py:728:5: C901 'AzurePlatform._get_location_info' is too complex (11)
.\lisa\sut_orchestrator\azure\platform_.py:809:5: C901 'AzurePlatform._create_deployment_parameters' is too complex (15)
.\lisa\sut_orchestrator\azure\platform_.py:1183:5: C901 'AzurePlatform._resource_sku_to_capability' is too complex (11)
.\lisa\tools\reboot.py:50:5: C901 'Reboot.reboot' is too complex (12)
.\lisa\util\process.py:63:5: C901 'Process.start' is too complex (12)
.\lisa\util\process.py:144:5: C901 'Process.wait_result' is too complex (13)

@dsrivastavv dsrivastavv added the good first issue simple issue to help onboard to LISA label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue simple issue to help onboard to LISA
Projects
None yet
Development

No branches or pull requests

1 participant