Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gVNIC 1.0.0 does not support checksum offloads(?), does it need to be fatal ? #51

Open
HaseebLUMS opened this issue Jan 23, 2025 · 2 comments

Comments

@HaseebLUMS
Copy link

I am running into the following fatal error while starting machnet.

=> Hardware does not support checksum offloads.

Driver information:
driver: gve
version: 1.0.0

capabilities (via ethtool -k)

tx-checksum-ipv4: off [fixed]

@HaseebLUMS
Copy link
Author

In the source code, here is the issue

// Making this fatal; not sure what NIC does not support checksum offloads.
LOG(FATAL) << "Hardware does not support checksum offloads.";

@sarsanaee
Copy link
Collaborator

Hi @HaseebLUMS

Would ya have a look at this commit 93f1472

Mainly, this particular file src/core/drivers/dpdk/pmd.cc

You are right and it does not have to be FATAL. Feel free to change it to WARNING and see if it solves your problem.

Also, feel free to create PR, and clean up GCP support. Happy to review and help out.

Thanks,
Alireza

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants