You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
PR #669 ("DataGrid allocs") optimizes allocations in the DataGrid control path, but no /perf workload instantiates a DataGrid, so the optimization cannot currently be measured or validated.
Evidence
Re-validated on current main (post-#692 + #665, the leaner baseline) — #669 reads textbook flat: StocksGrid alloc +0.1% [−0.9, +1.1], every headline/skip-floor/keyed block within noise, all 17 reconciler micro-benchmarks 0.0%. This is not a sign the PR is bad — it's that the StressPerf StocksGrid workload uses a native Grid, so the DataGrid code path is never entered.
Why it's a gap, not a no-op
This is the same situation #657 was in before StressPerf.KeyedList was added (the keyed-list workload converted #657 from "not-exercised" into a measurable −30% alloc win). #669 needs an analogous DataGrid-specific stress workload (a grid of N rows × M columns with realistic per-cell churn) before its allocation cuts can be judged.
Action
Add a StressPerf.DataGrid workload (disjoint new files, like the keyed-list workload).
What
PR #669 ("DataGrid allocs") optimizes allocations in the DataGrid control path, but no
/perfworkload instantiates a DataGrid, so the optimization cannot currently be measured or validated.Evidence
Re-validated on current
main(post-#692 + #665, the leaner baseline) — #669 reads textbook flat: StocksGrid alloc +0.1% [−0.9, +1.1], every headline/skip-floor/keyed block within noise, all 17 reconciler micro-benchmarks 0.0%. This is not a sign the PR is bad — it's that theStressPerfStocksGrid workload uses a nativeGrid, so the DataGrid code path is never entered.Why it's a gap, not a no-op
This is the same situation #657 was in before
StressPerf.KeyedListwas added (the keyed-list workload converted #657 from "not-exercised" into a measurable −30% alloc win). #669 needs an analogous DataGrid-specific stress workload (a grid of N rows × M columns with realistic per-cell churn) before its allocation cuts can be judged.Action
StressPerf.DataGridworkload (disjoint new files, like the keyed-list workload).Filed as a follow-up so the idea isn't lost; #669 itself is closed as not-currently-measurable.