Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add search function for Config Editor #424

Merged
merged 5 commits into from
Dec 13, 2024
Merged

Add search function for Config Editor #424

merged 5 commits into from
Dec 13, 2024

Conversation

ray007330
Copy link
Contributor

Description

We add search button on the user interface to enhance the usability.
image
It would be helpful when the number of knobs is large.

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Open a config xml file and then search for the key words you want

Integration Instructions

None

@github-actions github-actions bot added language:python Pull requests that update Python code impact:non-functional Does not have a functional impact labels Nov 27, 2024
@os-d os-d requested review from kuqin12, os-d and apop5 November 27, 2024 20:55
@makubacki makubacki added the type:enhancement New feature or pull request label Dec 2, 2024
@apop5
Copy link
Contributor

apop5 commented Dec 2, 2024

This looks fine, it just has a lot of print messages coming out that are debugging type information.

@ray007330
Copy link
Contributor Author

@microsoft-github-policy-service agree company="Microsoft"

@ray007330
Copy link
Contributor Author

@os-d @apop5 @kuqin12

I refactored the code and removed some unused print statement.
Do you have time take a look again?

@os-d os-d merged commit ad2d487 into microsoft:main Dec 13, 2024
12 checks passed
@ProjectMuBot ProjectMuBot mentioned this pull request Dec 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@os-d os-d os-d approved these changes

@kuqin12 kuqin12 kuqin12 approved these changes

@apop5 apop5 apop5 approved these changes

Assignees
No one assigned
Labels
impact:non-functional Does not have a functional impact language:python Pull requests that update Python code type:enhancement New feature or pull request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ray007330 @apop5 @os-d @kuqin12 @makubacki