Update aten_index_put implementation #2712
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesan Ramalingam <[email protected]>
Signed-off-by: Ganesan Ramalingam <[email protected]>
Signed-off-by: Ganesan Ramalingam <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2712 +/- ##
==========================================
+ Coverage 70.04% 70.06% +0.02%
==========================================
Files 226 226
Lines 27177 27262 +85
Branches 2734 2753 +19
==========================================
+ Hits 19036 19101 +65
- Misses 7197 7210 +13
- Partials 944 951 +7 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ganesan Ramalingam <[email protected]>
Signed-off-by: Ganesan Ramalingam <[email protected]>
xadupre
reviewed
Nov 21, 2025
| test(shape_6x6x6, [None, 0, [0, 1]], (6, 2), "contiguous_scalar_index_and_1d_index") | ||
| # (TODO): Exporter doesn't yet support all None indices | ||
| # test(shape_6x6x6, [None, None, None], shape_6x6x6, "all_none_indices") | ||
|
|
xadupre
reviewed
Nov 21, 2025
|
|
||
| # Bring advanced indices to front: | ||
| perm = advanced_indices + none_indices | ||
| transposed = op.Transpose(self, perm=perm) |
Member
There was a problem hiding this comment.
At some point, we should measure the performance of those additional Transpose. I don't think that's always the most efficient strategy (in term of computation performance). I wanted to avoid them in my PR (#2641).
xadupre
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update aten_index_put implementation in torchlib.