vmm_tests: enabling GP x64 memory validation tests (#2114)

Description:
Updating the GP x64 baseline numbers to account for internal repository
overhead, and enabling these tests for the pipeline.

Changes:
- Modified baseline values for GP x64 memory validation from hvlite data
collection
- Enabling GP x64 memory validation tests
- Adding threshold for kernel reservation

Author: dpaliulis-msft

vmm_tests/vmm_tests/test_data/memstat_baseline.json

@@ -7,8 +7,8 @@
                 "threshold": 1024
             },
             "reservation": {
-                "base": 18360,
-                "threshold": 0
+                "base": 18440,
+                "threshold": 512
             },
             "underhill_init": {
                 "Pss": {
@@ -47,8 +47,8 @@
                 "threshold": 3072
             },
             "reservation": {
-                "base": 23884,
-                "threshold": 0
+                "base": 23964,
+                "threshold": 512
             },
             "underhill_init": {
                 "Pss": {
@@ -86,12 +86,12 @@
         "vtl2_total": 524288,
         "2vp": {
             "usage": {
-                "base": 231334,
+                "base": 232418,
                 "threshold": 1024
             },
             "reservation": {
-                "base": 17664,
-                "threshold": 0
+                "base": 17668,
+                "threshold": 512
             },
             "underhill_init": {
                 "Pss": {
@@ -105,7 +105,7 @@
             },
             "openvmm_hcl": {
                 "Pss": {
-                    "base": 15097,
+                    "base": 16541,
                     "threshold": 512
                 },
                 "Pss_Anon": {
@@ -115,7 +115,7 @@
             },
             "underhill_vm": {
                 "Pss": {
-                    "base": 29054,
+                    "base": 32801,
                     "threshold": 1024
                 },
                 "Pss_Anon": {
@@ -126,12 +126,12 @@
         },
         "32vp": {
             "usage": {
-                "base": 254748,
+                "base": 255386,
                 "threshold": 3072
             },
             "reservation": {
-                "base": 24664,
-                "threshold": 0
+                "base": 24668,
+                "threshold": 512
             },
             "underhill_init": {
                 "Pss": {
@@ -145,7 +145,7 @@
             },
             "openvmm_hcl": {
                 "Pss": {
-                    "base": 15170,
+                    "base": 16116,
                     "threshold": 512
                 },
                 "Pss_Anon": {
@@ -155,7 +155,7 @@
             },
             "underhill_vm": {
                 "Pss": {
-                    "base": 37262,
+                    "base": 41883,
                     "threshold": 3072
                 },
                 "Pss_Anon": {
@@ -173,8 +173,8 @@
                 "threshold": 1024
             },
             "reservation": {
-                "base": 28952,
-                "threshold": 0
+                "base": 29036,
+                "threshold": 512
             },
             "underhill_init": {
                 "Pss": {
@@ -213,8 +213,8 @@
                 "threshold": 3072
             },
             "reservation": {
-                "base": 41676,
-                "threshold": 0
+                "base": 41764,
+                "threshold": 512
             },
             "underhill_init": {
                 "Pss": {
@@ -256,8 +256,8 @@
                 "threshold": 1024
             },
             "reservation": {
-                "base": 28884,
-                "threshold": 0
+                "base": 28972,
+                "threshold": 512
             },
             "underhill_init": {
                 "Pss": {
@@ -296,8 +296,8 @@
                 "threshold": 3072
             },
             "reservation": {
-                "base": 42356,
-                "threshold": 0
+                "base": 42440,
+                "threshold": 512
             },
             "underhill_init": {
                 "Pss": {

vmm_tests/vmm_tests/tests/tests/multiarch.rs

@@ -476,7 +476,7 @@ async fn guest_test_uefi<T: PetriVmmBackend>(config: PetriVmBuilder<T>) -> anyho
 }
 
 #[vmm_test(
-    // hyperv_openhcl_uefi_x64(vhd(windows_datacenter_core_2025_x64)),
+    hyperv_openhcl_uefi_x64(vhd(windows_datacenter_core_2025_x64)),
     hyperv_openhcl_uefi_aarch64(vhd(ubuntu_2404_server_aarch64))
 )]
 #[cfg_attr(not(windows), expect(dead_code))]
@@ -517,7 +517,7 @@ async fn memory_validation_cvm_small<T: PetriVmmBackend>(
 }
 
 #[vmm_test(
-    // hyperv_openhcl_uefi_x64(vhd(windows_datacenter_core_2025_x64)),
+    hyperv_openhcl_uefi_x64(vhd(windows_datacenter_core_2025_x64)),
     hyperv_openhcl_uefi_aarch64(vhd(ubuntu_2404_server_aarch64))
 )]
 #[cfg_attr(not(windows), expect(dead_code))]

vmm_tests/vmm_tests/tests/tests/multiarch/memstat.rs

@@ -23,6 +23,7 @@ use std::ops::IndexMut;
 use std::time::Duration;
 
 #[repr(u32)]
+#[derive(PartialEq)]
 pub enum TestVPCount {
     SmallVPCount,
     LargeVPCount,
@@ -197,7 +198,8 @@ impl MemStat {
     /// For all 2VP tests general usage and underhill_vm process memory usage are given a 1MiB threshold
     /// For all large (32VP or 64VP) tests general usage and underhill_vm process memory usage are given a 3MiB threshold
     /// All other processes have a usage threshold of 512kB
-    /// Kernel reservation has a threshold of 0 since there is no run-to-run variance with that statistic
+    /// Kernel reservation has a threshold of 512kB
+    /// In case any of these thresholds are exceeded, it would be considered a significant increase in memory usage from the previously established baseline (beyond run variance)
     fn compare_to_baseline(self, arch: &str, vps: &str) -> anyhow::Result<()> {
         let baseline_usage = Self::get_upper_limit_value(&self.baseline_json[arch][vps]["usage"]);
         let cur_usage = self.meminfo["MemTotal"] - self.total_free_memory_per_zone;
@@ -235,13 +237,6 @@ impl MemStat {
             );
         }
 
-        /*
-            Note on reservation test:
-                - Kernel reservation does not experience run-to-run variance and is not expected to change frequently
-                - Therefore the threshold for kernel reservation is 0
-                - If a code change must increase the kernel reservation, then the "base" value for the "reservation" statistic can be updated in memstat_baseline.json
-                - Occasional increases in the kernel reservation are expected, but should be noted in such an event
-        */
         let baseline_reservation =
             Self::get_upper_limit_value(&self.baseline_json[arch][vps]["reservation"]);
         let cur_reservation =
@@ -388,7 +383,7 @@ pub(crate) async fn idle_test<T: PetriVmmBackend>(
             }
         }
     };
-    let (mut vm, agent) = config
+    let vm_boot_result = config
         .with_processor_topology({
             ProcessorTopology {
                 vp_count,
@@ -402,7 +397,23 @@ pub(crate) async fn idle_test<T: PetriVmmBackend>(
             }
         })
         .run()
-        .await?;
+        .await;
+
+    // The VM is expected to fail to boot on the internal Intel pipeline only for the large VM size. We still want the AMD test to execute so
+    // we will keep the test and gracefully exit in case of a failure. Any other type of boot failure should still produce an error
+    if vm_boot_result.is_err()
+        && machine_arch == MachineArch::X86_64
+        && isolation_type.is_none()
+        && vps == TestVPCount::LargeVPCount
+    {
+        tracing::warn!(
+            "VM failed to start with the given topology, this is expected for the internal Intel runner only"
+        );
+        return Ok(());
+    }
+
+    let (mut vm, agent) = vm_boot_result?;
+
     let vtl2_agent = vm.wait_for_vtl2_agent().await?;
 
     // Wait for the guest to be booted