-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Statically parse selectors before executing tests #13332
Comments
Could you share with us what kind of typos you mean? Might be something for the ESLint plugin (#9474) or for the VSCode extension. |
I guess something malformed as |
Exactly. I think I had an extra |
Folding into #16972 |
I think there could be value to others who do not use vscode if this were done at the very start of the test run itself, but I do use vscode, so I won't complain. :). |
This is just an idea, but I found that sometimes I have a small typo in a selector, and it doesn't error until playwright actually tries to execute it, then I get a parse error. It might be nice to perform a static analysis of the selectors up-front, to fail fast. This might not always be possible (e.g. if the selectors aren't just string literals), but it might be useful at least as a "best effort" attempt.
The text was updated successfully, but these errors were encountered: