[Bug]: Origin Private File System is not isolated between tests

[karyon]

Version

1.42.1

Steps to reproduce

1. Clone https://github.com/karyon/playwright-examples
2. git checkout opfs-should-be-cleared
3. In VSCode extension, enable "Show Browser"
4. Run opfs test in opfs-should-be-cleared.spec.ts
5. Without closing the browser, run it again

Expected behavior

It succeeds twice

Actual behavior

It fails the second time

Additional context

https://playwright.dev/docs/browser-contexts uses very strong wording: "Every test runs independently from any other test. This means that each test has its own local storage, session storage, cookies etc. ... equivalent to incognito-like profiles ... completely isolated, even when running in a single browser."

This does not seem to apply to the Origin Private File System . The test in the example repo checks whether a directory exists and if not, creates it. The second run sees the directory created by the first one. For comparison, I wrote a similar test with localStorage, where it works as expected.

Environment

System:
    OS: Windows 10 10.0.19045
    CPU: (12) x64 Intel(R) Core(TM) i7-10850H CPU @ 2.70GHz
    Memory: 6.92 GB / 31.76 GB
  Binaries:
    Node: 18.17.1 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.21 - C:\Program Files\nodejs\yarn.CMD
    npm: 9.6.7 - C:\Program Files\nodejs\npm.CMD
    pnpm: 8.15.4 - C:\Program Files\nodejs\pnpm.CMD
  IDEs:
    VSCode: 1.85.2 - C:\Program Files\Microsoft VS Code\bin\code.CMD
  Languages:
    Bash: 5.2.26 - C:\Program Files\Git\usr\bin\bash.EXE
  npmPackages:
    @playwright/test: ^1.42.1 => 1.42.1

[mxschmitt]

https://playwright.dev/docs/browser-contexts uses very strong wording: "Every test runs independently from any other test. This means that each test has its own local storage, session storage, cookies etc. ... equivalent to incognito-like profiles ... completely isolated, even when running in a single browser."

While this statement is correct when running the tests on CI, via Terminal or via UI Mode, in VSCode this is only a best-effort approach as you discovered. We do this in order to provide a re-usable page experience instead of flickering / having a new page for each test. (So better DX while we hunt the edge-cases like this one).

Thanks for writing a test! I created a fix for it.

[mxschmitt]

Reopening since it caused a upstream Chromium bug, we'll revisit it in the future once the Chromium bug has been fixed.

[pavelfeldman]

Why was this issue closed?

Thank you for your contribution to our project. This issue has been closed due to its limited upvotes and recent activity, and insufficient feedback for us to effectively act upon. Our priority is to focus on bugs that reflect higher user engagement and have actionable feedback, to ensure our bug database stays manageable.

Should you feel this closure was in error, please create a new issue and reference this one. We're open to revisiting it given increased support or additional clarity. Your understanding and cooperation are greatly appreciated.

[karyon]

@mxschmitt it looks like the chromium bug was incidentally fixed. I don't need the fix anymore, but I'm wondering whether the fix should be re-applied, even though I do see there was no test in chromium added for it.

…

On August 16, 2024 2:31:11 AM GMT+02:00, Pavel Feldman ***@***.***> wrote: #### Why was this issue closed? Thank you for your contribution to our project. This issue has been closed due to its limited upvotes and recent activity, and insufficient feedback for us to effectively act upon. Our priority is to focus on bugs that reflect higher user engagement and have actionable feedback, to ensure our bug database stays manageable. Should you feel this closure was in error, please create a new issue and reference this one. We're open to revisiting it given increased support or additional clarity. Your understanding and cooperation are greatly appreciated. -- Reply to this email directly or view it on GitHub: #29901 (comment) You are receiving this because you authored the thread. Message ID: ***@***.***>