fix(reuse): reset Origin Private File System API #29921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mxschmitt
commented
Mar 13, 2024
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
bugfix/should-reset-Origin-Private-File-System
branch
from
de98288 to
45f3e0f
Compare
This comment has been minimized.
This comment has been minimized.
|
As agreed offline, let's do web api-based solution. |
mxschmitt
force-pushed
the
bugfix/should-reset-Origin-Private-File-System
branch
from
45f3e0f to
1a9d678
Compare
mxschmitt
commented
Mar 14, 2024
| @@ -212,7 +212,7 @@ test('should clean storage', async ({ runInlineTest }) => { | |||
| let lastContextGuid; | |||
|
|
|||
| test.beforeEach(async ({ page }) => { | |||
| await page.route('**/*', route => route.fulfill('<html></html>')); | |||
| await page.route('**/*', route => route.fulfill({ body: '<html></html>', contentType: 'text/html' })); | |||
There was a problem hiding this comment.
drive-by: it was never working before.
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
bugfix/should-reset-Origin-Private-File-System
branch
2 times, most recently
from
3b3fbd8 to
7ddc8d8
Compare
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
bugfix/should-reset-Origin-Private-File-System
branch
2 times, most recently
from
ba61e37 to
a04ee35
Compare
This comment has been minimized.
This comment has been minimized.
pavelfeldman
approved these changes
Mar 14, 2024
This comment has been minimized.
This comment has been minimized.
mxschmitt
force-pushed
the
bugfix/should-reset-Origin-Private-File-System
branch
from
a04ee35 to
05c48d9
Compare
mxschmitt
force-pushed
the
bugfix/should-reset-Origin-Private-File-System
branch
from
05c48d9 to
88e6d38
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"7 flaky26796 passed, 618 skipped Merge workflow run. |
mxschmitt
added a commit
that referenced
this pull request
Apr 11, 2024
…30342) This reverts commit 048d666. This change caused the crash for #30339 (comment). If we don't execute this code, it does not crash. Reverting it for now until the Chromium fix lands in Beta/Stable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29901
This clears the Origin Private File System API when using VSCode extension.