Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression]: Reporter API: steps after timed-out step are incorrectly located inside after hooks #30075

Open
vitalets opened this issue Mar 23, 2024 · 1 comment
Assignees
Labels
feature-test-runner Playwright test specific issues

Comments

@vitalets
Copy link
Contributor

vitalets commented Mar 23, 2024

Last Good Version

1.41

First Bad Version

1.42

Steps to reproduce

Check-out readme in the repo: https://github.com/vitalets/playwright-issues/tree/reporter-steps-inside-fixture

Expected behavior

I expect all steps to be on the top level of TestResult.steps.
E.g. step 2 title path is [ 'step 2' ]

Actual behavior

Step 2 title path is [ 'After Hooks', 'fixture: myFixture', 'step 2' ]

Additional context

No response

Environment

System:
    OS: macOS 13.4.1
    CPU: (8) arm64 Apple M1
    Memory: 472.55 MB / 16.00 GB
  Binaries:
    Node: 18.16.0 - ~/.nvm/versions/node/v18.16.0/bin/node
    Yarn: 1.22.21 - ~/.nvm/versions/node/v18.16.0/bin/yarn
    npm: 9.5.1 - ~/.nvm/versions/node/v18.16.0/bin/npm
    pnpm: 7.27.1 - ~/Library/pnpm/pnpm
  IDEs:
    VSCode: 1.87.2 - /usr/local/bin/code
  Languages:
    Bash: 3.2.57 - /bin/bash
  npmPackages:
    @playwright/test: 1.42.1 => 1.42.1
@yury-s
Copy link
Member

yury-s commented Mar 23, 2024

Reproduced it with 1.42, works fine in 1.41.2.

@yury-s yury-s added the v1.43 label Mar 23, 2024
@dgozman dgozman added v1.44 and removed v1.43 labels Mar 26, 2024
@dgozman dgozman added v1.45 and removed v1.44 labels Apr 25, 2024
@dgozman dgozman added feature-test-runner Playwright test specific issues and removed v1.45 labels May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-test-runner Playwright test specific issues
Projects
None yet
Development

No branches or pull requests

3 participants