Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add option whether to recreate worker after failure #34891

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

feat: add option whether to recreate worker after failure #34891

wants to merge 17 commits into from
+14 −2

Conversation

alexsch01
Copy link

@alexsch01 alexsch01 commented Feb 22, 2025 •
edited
Loading

needs tests and documentation

project repo I tested this PR with: https://github.com/alexsch01/TestProj_playwright

Should fix #32803

I would appreciate any feedback on this before moving forward with tests

@alexsch01
add skipAfterAnyFailure option (default: true) (#1)
a417629
@alexsch01
fix types
37d3962 
Signed-off-by: Alex Schwartz <[email protected]>
@alexsch01
take two
f411c0d 
Signed-off-by: Alex Schwartz <[email protected]>
@alexsch01
Update test.d.ts
90e962f 
Signed-off-by: Alex Schwartz <[email protected]>
@alexsch01
Update test.d.ts
9989b95 
Signed-off-by: Alex Schwartz <[email protected]>
@alexsch01
Update config.ts
aa5fed6 
Signed-off-by: Alex Schwartz <[email protected]>
@alexsch01
Update workerMain.ts
0b5b2be 
Signed-off-by: Alex Schwartz <[email protected]>
@alexsch01
Copy link
Author

@microsoft-github-policy-service agree

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@alexsch01
oops
7e724fd 
Signed-off-by: Alex Schwartz <[email protected]>
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@alexsch01 alexsch01 marked this pull request as ready for review February 22, 2025 12:35
@alexsch01 alexsch01 marked this pull request as draft February 22, 2025 13:20
@alexsch01 alexsch01 changed the title feat: add option whether to skip tests after failure feat: add option whether to recreate worker after failure Feb 22, 2025
@alexsch01
Update test.d.ts
a768716 
Signed-off-by: Alex Schwartz <[email protected]>
@alexsch01
Update class-testconfig.md
0a3f376 
Signed-off-by: Alex Schwartz <[email protected]>
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@alexsch01 alexsch01 marked this pull request as ready for review February 22, 2025 13:41
@alexsch01
Update class-testconfig.md
a78f915 
Signed-off-by: Alex Schwartz <[email protected]>
@alexsch01
Update workerMain.ts
579d865 
Signed-off-by: Alex Schwartz <[email protected]>
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@alexsch01
last time oops
8479108 
Signed-off-by: Alex Schwartz <[email protected]>
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Test results for "tests 1"

15 failed
❌ [playwright-test] › tests/hooks.spec.ts:512:5 › afterAll timeout should be reported, run other afterAll hooks, and continue testing @macos-latest-node18-1
❌ [playwright-test] › tests/playwright.trace.spec.ts:1236:5 › should record trace after fixture teardown timeout @macos-latest-node18-1
❌ [playwright-test] › tests/test-serial.spec.ts:178:5 › test.describe.serial should work with retry and afterAll failure @macos-latest-node18-1
❌ [playwright-test] › tests/hooks.spec.ts:512:5 › afterAll timeout should be reported, run other afterAll hooks, and continue testing @ubuntu-latest-node18-1
❌ [playwright-test] › tests/playwright.trace.spec.ts:1236:5 › should record trace after fixture teardown timeout @ubuntu-latest-node18-1
❌ [playwright-test] › tests/test-serial.spec.ts:178:5 › test.describe.serial should work with retry and afterAll failure @ubuntu-latest-node18-1
❌ [playwright-test] › tests/hooks.spec.ts:512:5 › afterAll timeout should be reported, run other afterAll hooks, and continue testing @ubuntu-latest-node20-1
❌ [playwright-test] › tests/playwright.trace.spec.ts:1236:5 › should record trace after fixture teardown timeout @ubuntu-latest-node20-1
❌ [playwright-test] › tests/test-serial.spec.ts:178:5 › test.describe.serial should work with retry and afterAll failure @ubuntu-latest-node20-1
❌ [playwright-test] › tests/hooks.spec.ts:512:5 › afterAll timeout should be reported, run other afterAll hooks, and continue testing @ubuntu-latest-node22-1
❌ [playwright-test] › tests/playwright.trace.spec.ts:1236:5 › should record trace after fixture teardown timeout @ubuntu-latest-node22-1
❌ [playwright-test] › tests/test-serial.spec.ts:178:5 › test.describe.serial should work with retry and afterAll failure @ubuntu-latest-node22-1
❌ [playwright-test] › tests/hooks.spec.ts:512:5 › afterAll timeout should be reported, run other afterAll hooks, and continue testing @windows-latest-node18-1
❌ [playwright-test] › tests/playwright.trace.spec.ts:1236:5 › should record trace after fixture teardown timeout @windows-latest-node18-1
❌ [playwright-test] › tests/test-serial.spec.ts:178:5 › test.describe.serial should work with retry and afterAll failure @windows-latest-node18-1

9 flaky ⚠️ [firefox-page] › tests/page/page-evaluate.spec.ts:403:3 › should throw for too deep reference chain @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/browsercontext-clearcookies.spec.ts:146:3 › should remove cookies by name and domain @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/proxy.spec.ts:63:3 › should work with IP:PORT notion @webkit-ubuntu-22.04-node18
⚠️ [webkit-library] › tests/library/trace-viewer.spec.ts:109:1 › should show tracing.group in the action list with location @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-event-popup.spec.ts:28:3 › should work with window features @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-filechooser.spec.ts:24:5 › should upload multiple large files @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-screenshot.spec.ts:345:5 › page screenshot › should work while navigating @webkit-ubuntu-22.04-node18
⚠️ [webkit-page] › tests/page/page-set-input-files.spec.ts:146:5 › should upload large file @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › tests/ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

38655 passed, 793 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature]: An option to NOT shutdown worker after test failure
1 participant
@alexsch01