Test results for "tests 1"

37596 passed, 648 skipped
✔️✔️✔️

Merge workflow run.

Hey @agg23 could you take a look please?

Scrollable toolbar isn't a great UX. I'd suggest overflow drop down style or expandable filter that takes entire row.

Thank you for the PR. I agree with Pavel; we probably want a dropdown here just like what happens to the TabbedPane when it docks to the side. However, since we do use a dropdown when TabbedPane docks to the side, we need to make sure there's enough visual clarity between the two dropdowns and that it is clear what each represents.

Yeah, I don't disagree with @pavelfeldman's point. Will update shortly and reach out. Thanks both

hey @pavelfeldman @agg23 would you guys be happy with this arrangement?

I would make the dropdown styled the same as the tabbed one above (left justify, at least). Also make it as small as possible to still render all of the filter labels without overflow.

Finally, we ideally want to switch to this dropdown form only once the parent block size decreases past a certain point.

hey @pavelfeldman @agg23 could you take a peek please? Once you're both happy I can clean things up and resubmit the changes.

I think that is suitable for now.

We discussed internally and we think it would be better if we had a proper overflow menu. As items move off of the screen, they should be added to a dropdown. Otherwise the options stay as top level buttons.

hey @agg23 I'm not likely to be able to commit time to finish this according to the new requirements in the next couple of weeks. If you wish to reassign or work on it, feel free to do so.

Thank you for the heads up. Feel free to open a new PR in the future if it hasn't been completed by the time you can work on it again.