Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Make it easy to identify what Inspector is associated to what window #34549

Open
alexbjorlig opened this issue Jan 30, 2025 · 3 comments · May be fixed by #34637
Open

[Feature]: Make it easy to identify what Inspector is associated to what window #34549

alexbjorlig opened this issue Jan 30, 2025 · 3 comments · May be fixed by #34637
Assignees
Labels

Comments

@alexbjorlig
Copy link

🚀 Feature Request

When writing tests for multiple windows, it's not easy to tell what Playwright Inspector window is associated with what window.

Maybe we could rename the "Playwright Inspector" window, use color themes, or other smart ways.

Example

Check here, where I just have 2 windows:

Image

Motivation

It will make Playwright better by enabling developers to keep their sanity while working on tests interacting with multiple windows. (for example realtime-sync tests)

@agg23
Copy link
Contributor

agg23 commented Jan 30, 2025

Do you have any suggestions on how we might accomplish this? What would a different window title signify? Colors aren't accessible, so that's not good enough.

@alexbjorlig
Copy link
Author

Do you have any suggestions on how we might accomplish this? What would a different window title signify? Colors aren't accessible, so that's not good enough.

It's a really good question, and it was very itentional that I did not mention a specific solution. But I think the screenshot makes it very clear, that something should be done 😅

What options could there be? What about patterns, if colors are not an option?

@agg23
Copy link
Contributor

agg23 commented Jan 30, 2025

I think for now we will add the browser URL, just like in Chrome Devtools, but that is often not unique.

For identifying the window in question, the "Record" and "Pick locator" buttons will both bring the corresponding browser window to the front.

@agg23 agg23 added the v1.51 label Jan 30, 2025
@agg23 agg23 self-assigned this Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants