Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: More precise Webkit version in changelog #34552

Open
dimkin-eu opened this issue Jan 30, 2025 · 4 comments
Open

[Feature]: More precise Webkit version in changelog #34552

dimkin-eu opened this issue Jan 30, 2025 · 4 comments

Comments

@dimkin-eu
Copy link

🚀 Feature Request

now both 1.49 and 1.50 have WebKit 18.2 in the changelog, but they are very different under the hood. Is there a way to add which exactly tech preview version is bundled?

Image

Example

No response

Motivation

Eliminating uncertainty about which version is being used.

@dimkin-eu
Copy link
Author

also, when pw downloads new browser version - some random number is shown

Downloading Webkit 18.2 (playwright build v2123) from https://cdn.playwright.dev/dbazure/download/playwright/builds/webkit/2123/webkit-mac-15.zip
68.6 MiB [====================] 100% 0.0s
Webkit 18.2 (playwright build v2123) downloaded to /Users/foobar/Library/Caches/ms-playwright/webkit-2123

I have feeling this is https://webkit.org/blog/16445/release-notes-for-safari-technology-preview-212/ but maybe I'm wrong

@agg23
Copy link
Contributor

agg23 commented Jan 30, 2025

Our WebKit version does not correspond directly to a Technology Preview but instead is based off of a particular commit at the point in time when we roll the browser. The Playwright build number is our version number as we must build versions of the browser with slight tweaks.

Would providing the source commit for WebKit be sufficient to your usecase?

@dimkin-eu
Copy link
Author

at least that much :)

@mirao
Copy link

mirao commented Jan 31, 2025

I would appreciate a link to WebKit project where the last commit was taken.
E.g. in Playwright 1.50, WebKit started to be unresponsive in one of our tests opening URLs that are present on a page, one by one and from the version WebKit 18.2 I can't recognize what changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants