Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handling forbidden combinations with except* #9416

Closed
erictraut opened this issue Nov 7, 2024 · 1 comment
Closed

Handling forbidden combinations with except* #9416

erictraut opened this issue Nov 7, 2024 · 1 comment
Labels
addressed in next version Issue is fixed and will appear in next published version enhancement request New feature or request

Comments

@erictraut
Copy link
Collaborator

Discussed in #9409

Originally posted by jakkdl November 7, 2024
I'm not sure how pyright wants to deal with syntax errors in general, but pyright currently doesn't flag any of the forbidden combinations from PEP-654 https://peps.python.org/pep-0654/#forbidden-combinations (mypy flags all of them)

There's probably some scenarios where this might matter for typing, and in case users aren't running other linters it might be good if pyright notifies the user immediately.
@erictraut erictraut added the enhancement request New feature or request label Nov 7, 2024
erictraut added a commit that referenced this issue Nov 7, 2024
@erictraut
Added checks for except* clause to report invalid usage that is fla…
0a7afec 
…gged as a syntax error at runtime. This addresses #9416 and #9413.
@erictraut erictraut mentioned this issue Nov 7, 2024
Merged
erictraut added a commit that referenced this issue Nov 7, 2024
@erictraut
Added checks for except* clause to report invalid usage that is fla…
76b81f3 
…gged as a syntax error at runtime. This addresses #9416 and #9413. (#9419)
@erictraut erictraut added the addressed in next version Issue is fixed and will appear in next published version label Nov 7, 2024
@erictraut
Copy link
Collaborator Author

This is addressed in pyright 1.1.389

@erictraut erictraut reopened this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addressed in next version Issue is fixed and will appear in next published version enhancement request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@erictraut