Skip to content

Commit daaee48

Browse files
author
Protik Biswas
committed
chnages after resolving conflicts
1 parent 13826ea commit daaee48

File tree

71 files changed

+288
-1141
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

71 files changed

+288
-1141
lines changed

.spelling

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -851,7 +851,6 @@ WDIO
851851
WEAKPTR
852852
WEAKREFCOUNT
853853
weakthis
854-
webdebugger
855854
webdriverio
856855
webhosthidden
857856
Wexceptions
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "prerelease",
3+
"comment": "Remove web debugging support",
4+
"packageName": "@react-native-windows/cli",
5+
"email": "[email protected]",
6+
"dependentChangeType": "patch"
7+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "prerelease",
3+
"comment": "Remove web debugging support",
4+
"packageName": "react-native-windows",
5+
"email": "[email protected]",
6+
"dependentChangeType": "patch"
7+
}
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
{
2+
"type": "prerelease",
3+
"comment": "TextInput is zero height when it has no content",
4+
"packageName": "react-native-windows",
5+
"email": "[email protected]",
6+
"dependentChangeType": "patch"
7+
}

docs/inspector.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ Hence, we expect most tooling available on other platforms to just work on Windo
1111
1. Initialize React Native Host,
1212
- Turn on `DeveloperSupport`
1313
- Turn on `FastRefresh`
14-
- Turn off `WebDebugger`
1514
- Turn on `Direct Debugging`
1615
2. Ensure Dev-Server is running
1716
3. Start the application

packages/@react-native-windows/cli/README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,6 @@ Here are the options that `npx @react-native-community/cli run-windows` takes:
9393
| `--emulator` | boolean | Deploys the app to an emulator |
9494
| `--device` | boolean | Deploys the app to a connected device |
9595
| `--target` | string | Deploys the app to the specified `GUID` for a device |
96-
| `--remote-debugging` | boolean | **(Deprecated)** Deploys the app in remote debugging mode |
9796
| `--logging` | boolean | Verbose output logging |
9897
| `--no-packager` | boolean | Do not launch the packager while building |
9998
| `--bundle` | boolean | Enable Bundle configuration, i.e. `ReleaseBundle`/`DebugBundle` rather than `Release`/`Debug` |

packages/@react-native-windows/cli/src/commands/runWindows/runWindows.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ function optionSanitizer(key: keyof RunWindowsOptions, value: any): any {
5959
case 'singleproc':
6060
case 'emulator':
6161
case 'device':
62-
case 'remoteDebugging':
6362
case 'logging':
6463
case 'packager':
6564
case 'bundle':

packages/@react-native-windows/cli/src/commands/runWindows/runWindowsOptions.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@ export type BuildConfig = 'Debug' | 'DebugBundle' | 'Release' | 'ReleaseBundle';
1919
* emulator: Boolean - Deploy to the emulator
2020
* device: Boolean - Deploy to a device
2121
* target: String - Device GUID to deploy to
22-
* remote-debugging: Boolean - Run using remote JS proxy
2322
* logging: Boolean - Enables logging
2423
* no-packager: Boolean - Do not launch packager while building
2524
* bundle: Boolean - Enable Bundle configuration.
@@ -40,7 +39,6 @@ export interface RunWindowsOptions {
4039
emulator?: boolean;
4140
device?: boolean;
4241
target?: string;
43-
remoteDebugging?: string;
4442
logging?: boolean;
4543
packager?: boolean;
4644
bundle?: boolean;
@@ -91,10 +89,6 @@ export const runWindowsOptions: CommandOption[] = [
9189
name: '--target [string]',
9290
description: 'Deploys the app to the specified GUID for a device',
9391
},
94-
{
95-
name: '--remote-debugging',
96-
description: '(Deprecated) Deploys the app in remote debugging mode',
97-
},
9892
{
9993
name: '--logging',
10094
description: 'Verbose output logging',

packages/@react-native-windows/cli/src/e2etest/runWindows.test.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ function validateOptionName(
2525
case 'emulator':
2626
case 'device':
2727
case 'target':
28-
case 'remoteDebugging':
2928
case 'logging':
3029
case 'packager':
3130
case 'bundle':

packages/@react-native-windows/cli/src/utils/deploy.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -380,9 +380,6 @@ export async function deployToDesktop(
380380
const vsVersion = Version.fromString(buildTools.installationVersion);
381381

382382
const args = [];
383-
if (options.remoteDebugging) {
384-
args.push('--remote-debugging');
385-
}
386383

387384
if (options.directDebugging) {
388385
args.push('--direct-debugging', options.directDebugging.toString());

0 commit comments

Comments
 (0)